Skip to content
OverviewSolutions
9
Comments
5
Pierre Allard
@RondellAllard

All comments

  • Pierre Allard•135
    @RondellAllardPosted almost 2 years ago

    Great job!

    Your design looks great!

    There seem to be a few accessibility issues,<main> </main> tags are required in all HTML pages for semantic reasons.

    So replacing the article tag you used with the main tag would be fine. You would also see some other issues on the page.

    I see no other issues.

    Good job!

    Marked as helpful
    0
  • Pierre Allard•135
    @RondellAllardPosted over 3 years ago

    Pretty much perfect!

    I'm curious why this project was labelled to include Javascript though, can you tell me?

    1
  • Pierre Allard•135
    @RondellAllardPosted almost 4 years ago

    Hi. Looks great!

    How come you have so many HTML and accessibility issues? Having those fixed makes you more attractive to employers

    0
  • Pierre Allard•135
    @RondellAllardPosted about 4 years ago

    I would look for where the desktop-sized screen stop looking good to make the breakpoint. I think I set mine to around 750px.

    0
  • Pierre Allard•135
    @RondellAllardPosted about 4 years ago

    Looks great. Pretty much identical!

    I, however, would have made the breakpoints a bit sooner so that you can get a smoother transition. At some screen sizes, it isn't functional.

    0