@Fikerte-TSubmitted 9 days ago
What specific areas of your project would you like help with?
Any suggestions to make the code efficient is appreciated.
Roman-oryol
@Roman-oryolAll comments
- @Roman-oryolPosted 8 days ago
Good implementation. I didn’t understand the JavaScript code, so the only thing I could suggest is to move the script code from the HTML file to a separate JS file
0 - @mikewil245Submitted 18 days agoWhat are you most proud of, and what would you do differently next time?
Dynamically updating the email when the user gets to the success message.
What specific areas of your project would you like help with?As far as my javascript, what could I have improved on ?
@Roman-oryolPosted 18 days agoHello. Since I'm still learning, I'm not sure if my advice will be helpful. I think styling the input and error message when a form submission fails is best done with CSS. You could create an error class for the block and style the elements that need different styles through this class. Then, when submitting, you only need to add one class, and all styles will be applied. Additionally, to quickly locate elements, you can find one parent element and then look for the child elements within it, because searching through the entire document is a more resource-intensive operation
Marked as helpful1 - @AbonsamaSubmitted 2 months ago
- @dattuannguyenSubmitted 3 months ago@Roman-oryolPosted 26 days ago
Hello. I think using grid in the Hero Block is unnecessary. The image can be added via background. You could also add a content width limit for desktop
0 - @marcus-hillSubmitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
My use of CSS grid in order to create the design layout, easily switching between mobile and desktop.
What challenges did you encounter, and how did you overcome them?Wasn't sure initially how to best structure the HTML, but I think it looks good.
What specific areas of your project would you like help with?The responsive nature of my design and the use of CSS grid.
@Roman-oryolPosted about 1 month agoI liked the solution. The layout implementation is good. The only thing missing is a hidden page heading for screen reader accessibility and headings for the review sections
0 - @MahdyrllSubmitted about 1 month ago@Roman-oryolPosted about 1 month ago
Great solution for overlapping cards at the transitional size. You could add a bit of semantics to the markup, such as headers in the cards and on the page. I think the images in the cards could be set as background images since they are more decorative than informative. The colored border of the cards is created using the border property, which results in rounded edges, not matching the design. To fix this, you can create the colored stripe with a pseudo-element without rounding, and set overflow: hidden on the card itself.
Marked as helpful1 - @temo1203Submitted about 1 year ago@Roman-oryolPosted 2 months ago
К сожалению, реализация совсем не соответствует макету. Здесь нечего комментировать.
0 - @MinThentSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I went a bit overkill with this one, used a lot of different components, passing data, mapping data and some conditional styling. Even after all that I'm thinking it lacks reusability.
What challenges did you encounter, and how did you overcome them?Of course, since I went overkill, I had to think of iterating logic and how to properly style looped elements. Also, the final table wasn't a walk in the park and went overkill again with conditional styling again.
What specific areas of your project would you like help with?I just want some advice to simplify the code and make the code's reusability improve as a whole. Any comment is helpful.
@Roman-oryolPosted 3 months agoThe composition of the components is well done. The code turned out to be reusable. But unfortunately the appearance is very different from the layout
0 - @SecretariatVSubmitted 5 months ago@Roman-oryolPosted 3 months ago
I think the buttons should be implemented as links, as it would be more semantically correct since they are supposed to lead to the author's social pages. Also, the font size doesn't match the design in the mockup. Additionally, I didn't see the implementation of the mobile version where the card itself is narrower and the inner padding is smaller
0 - @benesvojSubmitted 11 months ago@Roman-oryolPosted 3 months ago
I liked the solution with indentation through flex. I separately gave the lower margin to each element. Why does the card size differ so much from the layout?
0 - @haroonafzal9090Submitted 4 months ago
