temo1203• 150
@temo1203
Submitted
Roman-oryol
@Roman-oryol
All comments
- Roman-oryol• 50
@Roman-oryol
Posted
К сожалению, реализация совсем не соответствует макету. Здесь нечего комментировать.
0 - Min Thent Aung• 80
@MinThent
Submitted
What are you most proud of, and what would you do differently next time?
I went a bit overkill with this one, used a lot of different components, passing data, mapping data and some conditional styling. Even after all that I'm thinking it lacks reusability.
What challenges did you encounter, and how did you overcome them?
Of course, since I went overkill, I had to think of iterating logic and how to properly style looped elements. Also, the final table wasn't a walk in the park and went overkill again with conditional styling again.
What specific areas of your project would you like help with?
I just want some advice to simplify the code and make the code's reusability improve as a whole. Any comment is helpful.
Roman-oryol• 50@Roman-oryol
Posted
The composition of the components is well done. The code turned out to be reusable. But unfortunately the appearance is very different from the layout
0 - SecretariatV• 150
@SecretariatV
Submitted
Roman-oryol• 50@Roman-oryol
Posted
I think the buttons should be implemented as links, as it would be more semantically correct since they are supposed to lead to the author's social pages. Also, the font size doesn't match the design in the mockup. Additionally, I didn't see the implementation of the mobile version where the card itself is narrower and the inner padding is smaller
0 - Vojtech• 10
@benesvoj
Submitted
Roman-oryol• 50@Roman-oryol
Posted
I liked the solution with indentation through flex. I separately gave the lower margin to each element. Why does the card size differ so much from the layout?
0 - Haroon Afzal• 10
@haroonafzal9090
Submitted
Roman-oryol• 50@Roman-oryol
Posted
no comments
0
