@Suraj9505
Submitted
I am a beginner so please tell me if i can make it with simple method and reduce the code
@RikvanderSar
@Suraj9505
Submitted
I am a beginner so please tell me if i can make it with simple method and reduce the code
@RikvanderSar
Posted
Hey,
Great job on this challenge!
A couple of things I've noticed looking at your code.
Marked as helpful
@carlwicker
Submitted
Any feedback welcome.
1: I'm not sure why the validation doesn't like "all: unset".
2: Couldn't find a good solution for coloring the SVG social media icons on hover.
3: The generate screenshot function in FrontEndMentor doesn't render the patterns on my backgrounds although they work fine.
@RikvanderSar
Posted
Hi Carl,
Nice job on this challenge.
I don't know anything about React. But I've noticed two things that might be worthwhile to look at.
@GenesisX3
Submitted
Struggled a lot doing this one, trying to improve, feedback is welcome.
@RikvanderSar
Posted
Hi,
Just wanted to give you some quick feedback. Great job on this challenge! Just a couple of things you might want to take a look at:
Great job! Hope this feedback helps you a little bit further.
Marked as helpful
@titancode25
Submitted
Hey,
This was really awesome project as I was learning Grid CSS, Simple not much issues in this! Hope you love this content Developed by me!
@RikvanderSar
Posted
Hey man. Nice job!
Just wanted to give you some quick feedback. In the tablet / smartphone view you have some horizontal scrolling. It seems some content is overflowing. And you got some accessability issues in your markup that might need to be adressed.
@RikvanderSar
Submitted
Some tips and suggestions to further style the form elements would be great. I'd also would appreciate feedback on the readability of the code.
@RikvanderSar
Posted
Hi Matt,
Thank you for this helpfull feedback, really appreciate it! I'm definitly learning a lot from this project.
I'll get back at it with your feedback and will post a update soon!
Hi, this is my first project on frontend mentor, feel free to review my code, i will be glad to hear your view about it...thanks in advance.
@RikvanderSar
Posted
If you give your body a background image and have a child element for your card the card will lay on top of your background image. But you have to set a height and width for you body to display to full image. I'd go with height: 100vh
Marked as helpful
Hi, this is my first project on frontend mentor, feel free to review my code, i will be glad to hear your view about it...thanks in advance.
@RikvanderSar
Posted
Hi Adebayo,
Look good to me! If I compare your version with the design it looks like the inactive and active state of the links are vice versa. And I wonder why you've used a psuedo element for the background image. Wouldn't a background image on the body work as well and be less code?
Marked as helpful