@kct9281Submitted 5 months ago
Reza1878
@Reza1878All comments
- @Reza1878Posted 5 months ago
The result is good, but the repository url is wrong i think. i got 404 not found error when click it.
0 - @JOAN-96Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I am proud the time it took me to finish the task as I finished it much faster than I expected. If I were to do it again, I will make good use of the CSS flexbox.
What challenges did you encounter, and how did you overcome them?The challenge I had was aligning all the items to the center and I overcame them by:
- using the flex property,
- directing the flex to column, and
- aligning the items to the center.
@Reza1878Posted 5 months agoThe result is nice, but here's some point you can improve in your code:
- The font is not loaded on my side.
- Adjust the card placement to the center of the screen, you can use flex box in this case.
- Add alt attribute on img tag, so if the img failed to load it'll show the alternative text
0 - @bulgaagithubSubmitted 5 months ago@Reza1878Posted 5 months ago
The solution is good, the result is really close to design. But it'll be better if the img tag have alt attribute, so if the image is failed to load it will show the alternative text
Marked as helpful0 - @Shreyas235Submitted 5 months ago@Reza1878Posted 5 months ago
The solution is good, the result is similar with the design. It looks good in both small and large screen.
Marked as helpful0