Skip to content
OverviewSolutions
2
Comments
1
RedaKaafarani1
@RedaKaafarani1

All comments

  • Arnold Limberg•410
    @CreativeLogicSubmitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    I refactored this challenge. As my skills grew, I went back and reorganized the code to include custom properties and CSS nesting. Both are important in professional code bases, as they allow easier modifications and greater readability. Nesting, in particular, is a relatively new addition to CSS that makes CSS more enjoyable to read and write.

    What challenges did you encounter, and how did you overcome them?

    My attribution was pushing the card component up using regular Flexbox. I realized that in order to keep it how I wanted it without affecting the layout, I had to break it out of document flow, so I ended up using relative/absolute positioning to accomplish what I wanted.

    What specific areas of your project would you like help with?

    None for this particular project.

    QR Code Component

    1
    RedaKaafarani1•40
    @RedaKaafarani1Posted 6 months ago
    • no semantic HTML provided, index.html and style.css seem to be similar
    • The resizing of the screen doesn't seem to be affecting the layout but if we go below a certain range all becomes squished and goes to the top of the screen
    • The solution looks pretty neat and as close to the design as one can get
    • Code looks good with nesting and it's easy to follow along
    • It's nice that there are variables defined in :root to be reused later in the code. Wouldn't be that important in such a small project but why not.
    Marked as helpful
    0