Skip to content
OverviewSolutions
17
Comments
6
Rajesh Singh
@Rajeshsingh127

All comments

  • Rajesh Singh•280
    @Rajeshsingh127Posted almost 2 years ago

    Hi, you've done the DOM manipulation part correctly but the application is not responsive.

    0
  • Rajesh Singh•280
    @Rajeshsingh127Posted almost 2 years ago

    It looks similar to design so you did CSS fine. But it's not responsive. Also this project has 2 images one for desktop and one for mobile version and I believe the main purpose of this project was to understand how to use picture tag of HTML to adjust/change images accoriding to view width.

    0
  • Rajesh Singh•280
    @Rajeshsingh127Posted about 2 years ago

    Hi Vlad, I really like the fading animation of quotes. The design looks perfect however the text overflows the boundaries on screen size less than 270px. Also the font size is constant for both mobile and desktop size(it should change as screen size changes, check "clamp" property in css). Although it's not that important but if you want to make site fully responsive you've to take care of all edge cases.

    Marked as helpful
    1
  • Elaine•11,400
    @elaineleungSubmitted over 2 years ago

    I built another version of this challenge with React and wanted to try building one with plain JS, as the React version was more for practicing React again and I felt quite rusty, so the code wasn't as DRY as it could be. I also wanted to practice writing cleaner CSS since I have a bad habit of testing out a bunch of declarations and then seeing which one works. Plus there were other features I wanted to add but didn't get to (such as accessibility features and link simulation), and so I wanted to see if I can do that in just JS without React.

    I started by building out a small version on CodePen to practice skills I used in the last project, and then I reworked the existing HTML and some of the Sass from the React project. It took me quite a while mainly due to trying to put in new code while cleaning up my old code at the same time; this ended up being quite a good exercise in seeing what to do when you need to work with existing code and how to add new things without breaking it. I also tried to use less of CUBE CSS and BEM (or rather, a modified simplified version of my limited understanding of both).

    The biggest takeaway I had was, it's a good idea to use CodePen as a draft area to test things out first, and also to think seriously whether the CSS I wanted to write is really needed before writing it!

    Please feel free to let me know if anything is not working as it should be. Thank you all! 🙂

    Landing page with dropdown nav using plain JS

    5
    Rajesh Singh•280
    @Rajeshsingh127Posted about 2 years ago

    Hi Elaine! Excellent work. I'm a beginner and I'll take your code as a reference for wherever I get stuck. Thanks again..!

    0
  • Rajesh Singh•280
    @Rajeshsingh127Posted about 2 years ago

    wow man! I'm gonna refer your code is I get stuck

    0
  • Lucas 👾•104,400
    @correlucasSubmitted about 2 years ago

    👾 Hello, Frontend Mentor coding community. This is my solution for the NFT Profile Card Component.

    👻This the last of my old solution that I've cleaned the HTML code and CSS(even if is not the cleanest possible yet). Since now I'll submit only new challenges. I've changed a little bit the design and add some custom hover effect inside all elements card elements.

    • 🎨 Custom Gradient Design
    • 🥃 Color Spinning hover on text
    • 🎨 Custom Icon Hover effect

    Feel free to leave any feedback about my design chances and help me improve my solution or make the code clean!

    NFT Preview Card (Vanilla CSS + Custom Design and Hover Effects)

    8
    Rajesh Singh•280
    @Rajeshsingh127Posted about 2 years ago

    I don't have feedback. I'm a beginner and your code is helping me a lot!

    1