Skip to content
OverviewSolutions
4
Comments
4
Rahma Salah
@RahmaSalah59

All comments

  • Adam Whitehouse•130
    @adamwhitehouse95Submitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    Happy with the overall result, learned a few new things and now have this code as a referance. Next time would try to refine my code further, group css better etc.

    What challenges did you encounter, and how did you overcome them?

    I didnt know how to change the colour of ul and ol li's but a quick google changed that

    What specific areas of your project would you like help with?

    Anything and everything, all feedback is welcome as im sure its far from perfect

    Recipe Page

    1
    Rahma Salah•40
    @RahmaSalah59Posted 2 months ago

    great

    0
  • Rahma Salah•40
    @RahmaSalah59Posted 3 months ago

    good job

    0
  • Rahma Salah•40
    @RahmaSalah59Posted 4 months ago

    great work

    0
  • Rahma Salah•40
    @RahmaSalah59Posted 4 months ago

    Semantic HTML:

    Strengths: Ensure usage of semantic tags (<header>, <main>, <footer>, etc.). Improvements: Incorporate elements like <figure>, <nav>, <article> for better structure. Accessibility:

    Strengths: Use alt text for images and ensure keyboard accessibility for buttons. Improvements: Improve color contrast, use ARIA roles and properties for enhanced accessibility. Layout and Responsiveness:

    Strengths: Consistent layout with the original design. Improvements: Ensure responsiveness with CSS Grid or Flexbox, and check the QR code component scales properly. Code Structure and Readability:

    Strengths: Keeping CSS and JavaScript separate from HTML. Improvements: Use consistent indentation, meaningful class names, and modular JavaScript. Design Consistency:

    Strengths: Close adherence to the original design. Improvements: Match finer details like padding, margin, and font sizes for a pixel-perfect design. Summary The user’s implementation is a good start. Focusing on semantic HTML, accessibility, responsiveness, and code quality will enhance the solution, resulting in a more robust and user-friendly implementation.

    0