I enjoyed finishing this challenge but I'm still having problems with the background-image. As always, any suggestions are welcome!
Rene
@ProgrammerOfDeathAll comments
- @GiuliaT97Submitted over 1 year ago@ProgrammerOfDeathPosted over 1 year ago
Hi, also a nice solution. To have the right position of the background you could use background-size: contain; on your body. And than you could also get rid of the margin-bottom on your main-container. :)
Marked as helpful0 - @GiuliaT97Submitted over 1 year ago@ProgrammerOfDeathPosted over 1 year ago
Hi, very nice solution. Just one thing I noticed: I think this should be a full-sized header section. I would suggestion to use something like the grid layout, to put the content to the center. Then you can use something like height: 90vh on the body to have the footer more to the bottom of the page. :)
Marked as helpful0 - @moe-kaSubmitted about 2 years ago
🖤 night-mode - click on register button 💥 simple typewritter animation
@ProgrammerOfDeathPosted about 2 years agoHey, I like your solution. Nice animation and I like the typewriter effect. I would suggest to add a static break in the title, so it wouldn't break the line. Now it moves the content when breaking.
Marked as helpful1 - @moe-kaSubmitted about 2 years ago
🔻build with:
- HTML5
- CSS
- Vanilla JS
@ProgrammerOfDeathPosted about 2 years agoHey, nice work!
I would suggest to remove the second main tag and move the content of the both cards into a more reusable card component, cause the two cards share same styles and so on.
So there wouldn't be the sematic html error.
Happy coding!
Marked as helpful0