Skip to content
OverviewSolutions
2
Comments
2
Prantaneel Pegu
@Prantaneel-Pegu

All comments

  • N1Dovud•150
    @N1DovudSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    I was able to understand variable fonts, grid usage, and changing the font for smaller devices. The next time I try to spend less time on development of the project.

    What challenges did you encounter, and how did you overcome them?

    I did not know how to link fonts to my css. After doing some googling and understanding the properties for linking fonts, I was able to add them successfully!

    What specific areas of your project would you like help with?

    I guess with hovering part. I am not sure if the parent element should change when the heading is hovered or if when the parent itself is hovered, it should change.

    Blog-preview

    1
    Prantaneel Pegu•60
    @Prantaneel-PeguPosted 8 months ago

    I reviewed your code and I think you have written quite well! It quite matches with the original picture. The only recommendation I can give is to change the publish-date paragraph's font-size to 12px, like I found in the figma design file for the challenge.

    Marked as helpful
    1
  • CastonPursuit•20
    @CastonPursuitSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    How quickly I could get it done and use of grid.

    What challenges did you encounter, and how did you overcome them?

    Forgot I added a 200px height to img in HTML so while trying to resize in css spent a couple of mins trying to figure out why my image would change

    What specific areas of your project would you like help with?

    None

    QR Code with Grid

    1
    Prantaneel Pegu•60
    @Prantaneel-PeguPosted 8 months ago

    While you have done quite a good job, there is a major flaw in accessibility. Your site breaks in landscape mode for a mobile device with dimensions 320 * 675, which is the bare minimum a website should support. You can fix this by using responsive container sizes, typography and media queries. Also consider adding some more padding between the .qr-container and the inner text.

    Marked as helpful
    1