@DepramingoSubmitted over 2 years ago
- Is there a better way to center on component like this in the page?
- Is there a better way to do the overlay?
- Overall if you have any suggestions, please feel free to let me know
prakhar
@Prakhar-99All comments
- @Prakhar-99Posted over 2 years ago
Use ::after or ::before psedo selector for overlay rather than creating div for it
1 - @satya-hashSubmitted over 2 years ago
Feel free to provide your opinion about my code and your opinion is what I'm looking for. I found the most difficult part of this challenge is to make the landing page responsive. It took a lot of time to partially finish it. So I appreciate the feedback.
@Prakhar-99Posted over 2 years agohello @satya-hash here some advise that I think make your sollution quite good 1 add background-repeat = no-repeat and background-position = center, background size = cover in all your background container. 2.when you apply media query change the flex direction of container that contain egg background image . 3 add margin from left, right in content (h1, paragraph and button) of class " left & right". and give some specific width to para of this classes. 4 give specific width to para of classes orange and cherry like 80%-85%.
5.give a margin top and bottom in your testimonial section and give a width of 300 or 320px to your testimonia card and on flex wrap in testimonial card container thanks for read hope this can help you make your solution good
Marked as helpful0 - @bkaggleSubmitted over 2 years ago
I found it difficult on the media responsive part.
@Prakhar-99Posted over 2 years agomake main's display flex and set it width 100% and height 100vh and align and justify it content to center it help alot when you make it responsive try it
try bockground-size (cover) in image-content and background-position center it make your image go full in background i am not very good in english so please avoide some grammer mistake
0 - @j-likes-spicySubmitted over 2 years ago
Hey Everyone,
I found getting the image on the top of the card precise to be the most difficult part of this challenge. Also, on the mobile view, I didn't quite get the spacing right below the "Cancel Order" URL. I mostly enjoyed this challenge, as I really like building things out from Figma files. I gave BEM naming conventions a shot, although I think I'm not 100% correct. If there's anything I could have improved on, definitely let me know as I'm always open to any kind of feedback I can get.
Thanks!
@Prakhar-99Posted over 2 years agotry adding padding bottom to the container of your card it work for me many times
0
