Skip to content
OverviewSolutions
10
Comments
2
Rolly Castillo
@Pomz010

All comments

  • Sara Dunlop•430
    @RiscloverSubmitted over 2 years ago

    After posting, I'm seeing that I'm getting an accessibility issue. It's complaining that I don't have even a single <h1></h1> element on my page. What should I do in this case? Because I feel like this app definitely doesn't call for an h1 element. None of the text says "h1 header" to me, and I really don't want to change one label just to satisfy the accessibility requirement.

    Also, I tried to set it as an empty element, but it didn't like that and generated an additional issue, so I changed it back.

    So yeah. What would you guys suggest? Thanks!

    Tip Calculator App

    3
    Rolly Castillo•190
    @Pomz010Posted over 2 years ago

    Hi @Risclover, here's what I did to mine. I used an actual h1 tag instead of using the image asset provided for the logo then styled the header to replicate the logo design. Here's the css code I used to style the header as h1 tag.

    h1.header { text-align: center; text-transform: uppercase; letter-spacing: .5rem; margin: 2rem auto; width: 109px; height: auto; word-wrap: break-word; line-height: 2.5rem; color: hsl(186, 14%, 43%); font-size: 1.5rem; }

    1
  • Rolly Castillo•190
    @Pomz010Posted over 2 years ago

    Made an update regarding layout issues on 1440px breakpoint. Kindly click preview site to view actual page layout. The solution view doesn't seem to update if you've made changes from the initial submission of the challenge.

    0