All comments

• 

  Tanobia• 90

  @Tanobia

  Submitted over 1 year ago

  My second project was less time consuming then the first one since I relied on flexbox instead of position. This led to way less subsequent problem solving and a better overview of my code. Feedback and notes would be appreciated. Thanks.

  

  QR Code Component Solution

  1

  30

  

  Philippe Brand• 60

  @Pipos645

  Posted over 1 year ago

  Nice work !

  My suggestions to make your website a little bit better are the following :

  • to center your card (and make sure it will always be) put your card inside a parent div with the following css :

  yourParentDiv{
   width: 100%;
   min-height: 100vh;
   justify-content: center;
   align-items: center;
  }
  

  this way your card will be centered inside a div that is the size of the screen.

  another little tip for the border-radius:

  • you did border-radius: 5% which makes the border-radius look like it's not centered with the corner

  • you can do border-radius: 20px for a prettier result!

  Marked as helpful

  1

  This comment has received 1 replyShow