Skip to content
OverviewSolutions
1
Comments
1
Piotr Pieprzyk
@PiotrPieprzyk

All comments

  • VovaKuzmenko•40
    @VovaKuzmenkoSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    I don't know

    What challenges did you encounter, and how did you overcome them?

    Vertical positioning

    What specific areas of your project would you like help with?

    The project is small. Look. Tell me in your opinion: what is good, what is bad, what can be improved

    respinsive landing page GRID, BEM

    1
    Piotr Pieprzyk•10
    @PiotrPieprzykPosted 6 months ago

    Overall, it looks good, there are small things that I would improve.

    • The border-radius for the image is a bit too large. What's more you don't have to repeat 20px 4 times, you can enter 20px once.
    • You could try to install an extension such as eslint or prettier to automatically improve the style of your code. I saw unnecessary nesting in the css file or an empty style under the .main { class
    • if you would like to use the BEM methodology, I think the .text-block__large class should be called .text-block--large. --large is more of a modifier.

    Have a nice day!

    0