@TechGuySaad
Submitted
@Paulo-Dandrea
@TechGuySaad
Submitted
@Paulo-Dandrea
Posted
Very nice solution using Redux and Router. It was very clarifying for me. This challenge is very good train that.
For the buttons on Rating.jsx, don't you think using a .map() would be cleaner? Less repeatable? Also, could be a good idea to componetize that. I think. What do you think?
Anyway, I'm favoriting here to help me with Redux or Router if I would use later.
Marked as helpful
@LanXhan
Submitted
@Paulo-Dandrea
Posted
Congratulations for the solution.
I've noticed that you're using the indentation to nest things, right? They do not use this way in the industry.
box-sizing:border-box
for your reset as well? It is a more intuitive way to layout things.*,
*::before,
*::after {
margin: 0;
padding: 0;
box-sizing: border-box;
}
@Ramonlleopoldo
Submitted
Bom desafio para iniciantes, bem rápido de fazer.
@Paulo-Dandrea
Posted
Parabéns pela solução!
Vi que acabou não colocando as cores das fontes. Por que não aproveita e cria variáveis com as cores e aí pode usar onde quiser.
Exemplo:
:root {
/* Color variables */
--color-dark-blue: hsl(218, 44%, 22%);
/* Font variables */
--font-primary: "Outfit", sans-serif;
}
h1 {
color: var(--color-dark-blue)
}
Tente organizar seu CSS em que os seletores fiquem ordenados por tipo ou especificidade, por exemplo:
body {} h1,h2, etc{} .display{}