@P-Mingi
@mussieh
Submitted
What are you most proud of, and what would you do differently next time?
I was able to practice my CSS grid skills.
What challenges did you encounter, and how did you overcome them?
I faced a challenge arranging the grid but was able to figure it out in the end.
What specific areas of your project would you like help with?
I would love any feedback on the correctness of my approach.
@P-Mingi
Posted
It's really good.
I think you should put a min-width for your media query to make it shrink less.
I like the way you organized your css, but i think you complicated yourself too much in your html structure organisation, mayber there are too much "div" and 'class" :)
Marked as helpful
@manishsinghraj
Submitted
What are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?
.
What specific areas of your project would you like help with?
.
@P-Mingi
Posted
Your website look exactly like the design asked. and it is well responsive as well.
I really like your :root organisation.
@Donitron
Submitted
What are you most proud of, and what would you do differently next time?
Very proud of the responsiveness!
What challenges did you encounter, and how did you overcome them?
Started the desktop layout with a flexbox but it was hard to make the image fit the entire half section of the card. Switched to a column layout instead.
What specific areas of your project would you like help with?
Nothing specific, any feedback is welcome
@P-Mingi
Posted
I this really good, i think you just forgot the effect on the button which is not a big deal haha. I got nothing more to say it is really good :)
@David-dawn
Submitted
What are you most proud of, and what would you do differently next time?
Nothing basically
What challenges did you encounter, and how did you overcome them?
None
What specific areas of your project would you like help with?
None
@P-Mingi
Posted
I can see that you know how to do it but just felt lazy to make it perfect...
There probably a lot of thing that you can improve but your code is good i think, don't forget to put a "main" to englobe all of your "div" inside your body. Your html structure look a little bit messy, i don't think that using an header or nav was useful.
@Nasserio10
Submitted
What are you most proud of, and what would you do differently next time?
i create layout i centered it with flexbox tool.
What challenges did you encounter, and how did you overcome them?
sizing the text and paragraph ,and also the font family that i downloaded it and applied it.
What specific areas of your project would you like help with?
responsivness and howering.
@P-Mingi
Posted
The result looks exactly like the requested design :)
I think that the "div" containing the ".container" class is useless, the main would have been enough.
I think it is also useless to put the "a" in "div", just assign the class in the "a" link.
I think it's better to put: in the * {} selector margin: 0; padding: 0; box-sizing: border-box;
but I think the rest is perfect :)
@osenprema
Submitted
What are you most proud of, and what would you do differently next time?
I learned how to work with FIGMA files.
What specific areas of your project would you like help with?
Any feedback welcome ;)
@P-Mingi
Posted
The result is very good, it's exactly what it should look like. I find the structure of your HTML5 well constructed.
However, I'm having a little trouble with the organization of the css which doesn't seem well organized to me, it's hard to find my way. I also think that this project did not require as many lines of css, there were, I think, simpler ways of doing it. I don't think we need @media query either, the code is too bloated.
but you seem to use special tools (which I also don't have knowledge of) like "last-of-type" for example, I don't think this is useful. I think it's better to use many classes instead.
I'm a beginner so what I say may not be right, and I'm not writing with bad intentions :)
Marked as helpful
@FayeVinyl
Submitted
What are you most proud of, and what would you do differently next time?
The design looks fairly close, the text needs to be moved up a tiny bit
What challenges did you encounter, and how did you overcome them?
Getting the spacing between elements pixel perfect
What specific areas of your project would you like help with?
n/a
@P-Mingi
Posted
It look exactly like the sample. I think that usually i will not use px for my width, but because of that your website look exactly like the sample, and it is perfectly responsive.
everything look well structured, and the * {} is well initialized.
