Frontend Mentor | Otávio's profile

@jesuisbienbienSubmitted over 2 years ago

This is my first project working with API.

I notice that if I click on the button twice in a row, it will not generate a new advice as I expected it. If I click again, then it works. Any suggestions on how to fix that?

Any other feedbacks are welcome as well :)

Advice Generator App (using flexbox, vanilla JS, API)

1

Otávio•230

@Otavio-CiprianoPosted over 2 years ago

Hi there good job completing this challenge

So that's not an issue in your code. If you request too fast to this API, it is going to return the same response, there's a note about this in the API documentation. They cache your request for 2 seconds, so any repeat-request within 2 seconds will return the same piece of advice

I hope this helps

Cheers!

Happy coding 👍

Marked as helpful

0

Bruna Felix•100

@brunafelix79Submitted over 2 years ago

alguém poderia me ajudar aqui???????????

cartão de perfil

1

Otávio•230

@Otavio-CiprianoPosted over 2 years ago

hi there good job completing this challenge!

I'm not sure if reply in portuguese is against the guidelines, but I'll try.

Pude ver que você não teve nenhuma dificuldade em posicionar o card e o background, no entanto, teve dificuldades no posicionamento dos elementos de texto.

Então aqui algumas dicas e observações.

O motivo daquelas informações de seguidores, fotos e curtidas. Terem ficado de fora do elemento de class "card", foi porque elas não estão dentro do elemento de class "card". No entanto, mesmo se você colocasse elas dentro do elemento card o posicionamento ainda não estaria correto, pois você deu height: 100% para o elemento de class "card-description". Ou seja, se você remover esse height: 100%, colocar o "card-footer" dentro de "card " e der um border-top para o "card-footer", acredito que sua solução ficara mais próxima do design original.

I hope this helps!

Cheers!

Happy coding 👍

0

geoffjecrois•390

@geoffreyhachSubmitted over 2 years ago

About the javascript form validation, is it the best practice to create a new function for every input like I did?

-I couldn't find how to add the svg icon in the input field, any suggestion? I tried to use a pseudo element on the error message span, but i couldn't position it like I wanted. EDIT : with the label elements that i forgot right?

-I did a desktop first version but I should have start with mobile I guess.

Javascript form validation

2

Otávio•230

@Otavio-CiprianoPosted over 2 years ago

Hey there, good job completing this challenge.

Some advices

Try to give name to all input on the html
During the submit event you don't need to access the document again to select the input inside the form, you could select them using that "const myForm" and accessing the input by name

example:

let email = myForm['email']

You could also use all that validation code inside the same eventListener function, because is the same event to the same element, there's no reason to separate that.

I hope this helps and it didn't sound rude or weird.

Cheers!

Happy coding 👍

Marked as helpful

1