Skip to content
OverviewSolutions
8
Comments
10
Aram
@OhSorrow

All comments

  • Chard Largodizimo•270
    @chardlargodizimoSubmitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    Hey there! I'm excited to share that I've completed the challenge, although it did take me a bit of time. I made some enhancements, including a feature that will greet you with a happy birthday if today's date matches your birthdate.

    I tweaked the error message for the year input to be more user-friendly and set the starting year to 1700. Now, instead of saying "must be in the past," it simply states "must be a valid year." This adjustment covers a broader range, ensuring it works smoothly from the year 1700 and beyond.

    What challenges did you encounter, and how did you overcome them?

    I have a hard time coming up with a solution for calculating the age.

    What specific areas of your project would you like help with?

    I need someone to test if the app I made is working correctly.

    Age calculator app using HTML, CSS and JS

    1
    Aram•280
    @OhSorrowPosted 9 months ago

    Great job🎉

    The "happy birthday" message and the singular forms of "year", "month", and so on were nice touches! I suggest you use <input type="text" inputmode="numeric"> or <input type="number"> to make the user's keyboard numeric.

    Keep coding 🔥

    0
  • Aram•280
    @OhSorrowPosted about 2 years ago

    Hey dear Imen! Congratulations for completing this challenge! 👏

    As far as I can see, the feedback flex items are not centered on desktop layout. You can fix it by adding the following piece of code:

    .feedback {
    justify-content: center;
}

    Note: Instead of using margin-left, use gap property for flex-items.

    Happy coding :)

    Marked as helpful
    1
  • Alfred Garcia•80
    @Alfred-GarciaSubmitted about 2 years ago

    Please take a moment to review my code and let me know how I can improve. I feel like I need the most help in selecting class names that make sense. I tried using the BEM naming convention but I don't feel like I have it just right yet.

    Anyway, looking forward to any advice folks are willing to provide.

    Responsive Testimonials Grid

    2
    Aram•280
    @OhSorrowPosted about 2 years ago

    Hey dear Alfred! Congratulations for completing this challenge 👏

    I suggest you using q element for short quotes, and blockquote element for long quotes.

    Happy coding :)

    Marked as helpful
    0
  • Aram•280
    @OhSorrowPosted about 2 years ago

    Hey dear Vitório! Congratulations for completing this challenge! 👏

    I suggest you importing mobile background patterns (top and bottom patterns) for displays up to about 900px wide. Because now the background patterns are not OK for the displays larger than 375px and less than 700px.

    I hope it helps you to get a better result :)

    Marked as helpful
    0
  • Aram•280
    @OhSorrowPosted about 2 years ago

    Hey dear anass sanba! Congratulation for completing this JUNIOR challenge!

    I suggest you setting a max-width of 1200px on the main to prevent stretching the page on desktop displays.

    I hope it helps you :)

    Marked as helpful
    1
  • Aram•280
    @OhSorrowPosted about 2 years ago

    👋 Hey dear Cheosphere! Congratulation for completing this challenge! It looks great!

    One suggestion I have is to use li tags inside a ul tag instead of br tags inside a p tag in the following piece of your HTML code:

      <section class="card_content_right">
        <h2 class="card_content_right_title">
          Why Us
        </h2>
        <p class="card_content_right_text">
          Tutorials by industry experts<br>
          Peer & expert code review<br>
          Coding exercises<br>
          Access to our GitHub repos<br>
          Community forum<br>
          Flashcard decks<br>
          New videos every week
        </p>
  </section>

    Happy coding ;)

    Marked as helpful
    1
  • Aram•280
    @OhSorrowPosted about 2 years ago

    Hey dear Omer! Congratulations for completing this challenge! 👏

    I suggest you using blockquote element, instead of using span element (which is not semantic and is an inline element) for the quote part.

    Happy coding!

    Marked as helpful
    1
  • Abdukadir•20
    @abdukadir037Submitted about 2 years ago

    Hello frontendmentor community, i tried Product Preview Card Component challange. If you've any feedback or suggestion Welcome

    Product Preview Card

    1
    Aram•280
    @OhSorrowPosted about 2 years ago

    Hey dear Abdukadir and congratulation for completing this challenge!

    I suggest you using semantic HTML tags like article for the card, instead of using lots of div tags. You can also use footer tag for the information at the bottom of the webpage!

    Happy coding!

    Marked as helpful
    1
  • Aram•280
    @OhSorrowPosted about 2 years ago

    GitHub Pages is a great choice to host your website. Take a look at this instruction. If you have any question, feel free to ask!

    1
  • Aram•280
    @OhSorrowPosted about 2 years ago

    Hey dude! I hope this piece of code helps you to use the background pattern:

    body {
  background-image: url(THE PATH OF PATTERN);
  background-repeat: repeat-x;
  background-size: contain;
  height: 100vh;
}

    The path inside the url() parentheses , is the path of the pattern image.

    Please let me know if you have any questions.

    Happy coding!

    Marked as helpful
    0