Skip to content
OverviewSolutions
4
Comments
4
EMMANUEL
@NueloSE

All comments

  • EMMANUEL•80
    @NueloSEPosted 4 months ago

    Great job. BTW

    • In your html implementation i noticed
    tr>
          <td> Calories</td>
          <td id="thick-data">277kcal</td>
        </tr>

        <tr>
          <td>Carbs</td>
          <td id="thick-data">0g</td>
        </tr>

        <tr>
          <td>Protein</td>
          <td id="thick-data">20g</td>
        </tr>

        <tr>
          <td>Fat</td>
          <td id="thick-data">22g</td>
        </tr>

    recall id is meant to be for unique entities so a class would have been better for "thick-data"

    and kindly use nnemonic variable naming convension ex: instead of thick-data use nutrition-quatity

    finaly kindly take out the Challenge by Frontend Mentor. Coded by Thelma Maxwell. put it outside the recipe card just below the recipe card

    Marked as helpful
    0
  • Muhammad Umair Ali•90
    @bossthekhaniSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of that I am clearing out the design thinking 💭

    What challenges did you encounter, and how did you overcome them?

    The challenges I didn't face yet.

    What specific areas of your project would you like help with?

    ..

    Responsive Social Links Profile

    2
    EMMANUEL•80
    @NueloSEPosted 4 months ago

    Great job done so far. kindly improve on the following:

    1. update the readme file in the root directory to suit you and take out the placeholder text
    2. Try and center the social media card and the challenged by ... should be under the card.
    3. The first btn linking to github should not be green by default it should only change to green when hover on like the other buttons do.

    Again awesome job

    Marked as helpful
    1
  • EMMANUEL•80
    @NueloSEPosted 4 months ago

    1. Kindly check and update the preview link, it links to another project at:https://dnyanesh-bachhav.github.io/Frontend-Mentor-Challenges/

    2. update the readme file on the main project page to contain a description of the project: https://github.com/Dnyanesh-Bachhav/Frontend-Mentor-Challenges/blob/Blog-Preview-Card/readme.md

    BTW LGTM

    0
  • josemills•60
    @josemillsSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    Estoy orgulloso del desarrollo dado que ocupe técnicas que ya conocía anteriormente y que me sirvieron para el desarrollo de este proyecto.

    What challenges did you encounter, and how did you overcome them?

    Me costo trabajo parte del CSS, ajustar los tamaños del box y de la imagen

    Profile-Card

    1
    EMMANUEL•80
    @NueloSEPosted 4 months ago

    Great job done so far. But kindly work on improving the responsiveness of the site so as to suit mobile version. BTW LGTM great job

    0