@MiguelPositiveSubmitted over 1 year ago
Nermen
@NermenElefkyAll comments
- @NermenElefkyPosted over 1 year ago
Hi there 👋. congratulations on completing the challenge👍You have done great work.
I have some suggestions you maybe interested about:
- Form validation isn't work properly which means when I click in confirm button and inputs are blank, The page display "thank you" section.
- When I filled the card number input with Numbers, the "Wrong format, numbers only" appears and then when I filled it with letters , The message doesn't appear.
- When I filled the form , The data doesn't appear in the bank cart.
- The "circle" icon is very small (in mobile & tablets).
have a nice day
0 - @adil-khursheedSubmitted over 1 year ago
Hey Everyone,
This is my first project with context api. Your feedback is much appreciated 🙂🙂
Regards.
@NermenElefkyPosted over 1 year agoHi there 👋.Congratulations on successfully completing the challenge 👍You have done great work !!
I have some suggestions you maybe interested about:
- Cart icon is a bit small.
- The font size of the counter on the cart is very small.
- When I clicked "Add to car" button and then I removed the items from the cart and then I clicked the button again, The button doesn't work.
- Would be nice if you add different styles to the active thumbnail.
- The links list doesn't take the full height of the page (in mobile).
- Would be nice if you add the ability to click anywhere to close the backdrop overlay.
- There is no visual feedback after clicking "Add to cart" button indicating an action has occurred.
Above all, Your effort is greatly appreciated.
Have a nice day 😊
Marked as helpful1 - @AhmadYousif89Submitted over 1 year ago
Hi There 👋
This is my second upload for this challenge, I just added new features to the application and I thought it might be a good idea to post these updates to hear your thoughts and listen to your valuable feedback 🤗.
update summary
- added the product's favorite logic (the ability to like and add a sneaker to the favorite list)
- the ability to search inside the favorite list by the product name.
- added the order list logic and the order page to preview the order details after checkout.
- added the logic to track the user viewing history per product (for now it's just the main product so only one product can be added to the history).
- some minor styling changes.
- the app state is persisted over sessions locally.
that's all for now, please feel free to leave any feedback or suggestions that you might find helpful to the app, Thanks.
@NermenElefkyPosted over 1 year agoHi Ahmed 👋
You have done great work. The design is really good. But I think this professional website needs custom scrollbar. Above all, your efforts are greatly appreciated.
0 - @PeterFarberSubmitted almost 2 years ago@NermenElefkyPosted almost 2 years ago
Hi Peter👋 good job on completing the challenge. You put a lot of effort on it.
I have some suggestions which may interest you:
- You need to improve the website to be responsive (CSS flex & grid may help you).
- The sidebar should be responsive to the user (when I click on any step, The info of this step should be displayed).
- The (next step button) in the (personal info section) should check that all the input fields are filled with the right info before moving to the next step (you can use regular expression to make form validation).
- The (total) in the (finishing up) section does not work correctly.
I hope you find them useful
Have nice time with coding
0 - @drisskhattabi6Submitted almost 2 years ago@NermenElefkyPosted almost 2 years ago
Hi there👋, Good job on completing the challenge.
I have some changes which may help you:
-
You can change the color of the logo from the svg file, you can change the value of fill attribute.
-
In the header part, I think if you give the image and div(class = "description") width less than 50% in order to make some space between them and make the div.content (justify-content: space-between) will be nicer.
I hope you find them useful
Marked as helpful1 -
- @Eyas1996Submitted almost 2 years ago@NermenElefkyPosted almost 2 years ago
Hi Eyas 👋, Good job on completing the challenge.
I have some changes which may interest you
-
you can load your image background using background-image: url(../images/bg-hero-desktop.svg).
-
Your page is not responsive. check this link will help you to achieve that (you can use CSS flex and grid will help you a lot).
-
Use HTML semantic elements.
I hope you find them useful
Have nice time with coding
0 -
- @salva323Submitted almost 2 years ago@NermenElefkyPosted almost 2 years ago
Hi salva, Good job on completing the challenge👌
Here are some suggestions which may interest you
-Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). Swap the <h3> tag with <h1>.
-You can center the content of the page using CSS flex or grid.
-Switch <h4> with <p>, its is just a paragraph not a heading.
I hope you find them useful😄.
Have nice time with coding.
0 - @rafaelmarquesRMSubmitted almost 2 years ago@NermenElefkyPosted almost 2 years ago
Hi Rafael, Good job on completing the challenge👌 Here is some suggestions that I have received as a feedback before
- Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). Swap the <h2> tag with <h1>.
- Use the <main> element to wrap all your content instead of <div>.
I hope you find them useful. Happy Coding.
0 - @CosmicGarou18Submitted almost 2 years ago
Please checkout my first beginner project : The QR Code Challenge. Can someone explain how would I make it so that when i shrink the page thecontent stays in the box and does not overflow
@NermenElefkyPosted almost 2 years agoI recommend not determining the height of element (in your Ex : the main div do not give it a height). Good job.
1
