NeonCodes
@NeonCodesAll comments
- @hieutran249Submitted 3 months ago@NeonCodesPosted 2 months ago
Hello , good job completing the challenge! It looks similar!
First, the positive: The card is well centered with flexbox. All elements are present and with the font-style in the style guide. I forgot about
span
and how it helps with styling. That's a nice reminder.Second, potential areas of improvement: The corners of the card seem a bit bigger than the photo. You can try
10px
for theborder-radius
. Andborder-radius:4px
for the learning tag. Also, if you want to learn focus and hover states there is this article on web dev Focus-web-devI hope it helps.
Happy coding!
0 - @Perry2004Submitted 3 months ago@NeonCodesPosted 3 months ago
Hello, Good job completing the challenge! The design is pretty close to the original.
First, the positive:
- Your code is very concise and well-organized so we don't get lost while reading it (special mention for the
#description
selectors and@media
in the stylesheet) - Didn't know
font-optical-sizing
existed, that's nice. - The card is well-centered and sized with flexbox.
Second, potential area of improvement:
- The
h1
seems slightly too big. You can tryfont-size:22px
( or convert them to rem using a converter like Calculatorway)
I hope it helps. Happy Coding!
0 - Your code is very concise and well-organized so we don't get lost while reading it (special mention for the