Skip to content
OverviewSolutions
18
Comments
2
Jonathan
@Nathan-Front

All comments

  • Jonathan•295
    @Nathan-FrontPosted about 3 years ago

    Good job on this, design looks great, although some things to point out.

    1. The action="" of your form should not be empty, try adding # in it to stop the html error
    2. The error image is not displaying when error is being displayed.
    3. Email validation is not being checked even when I enter wrong email format.
    4. As a newbie in form validation just like me, there are better ways to do it so I recommend you check this out. It was super helpful for me: (https://www.youtube.com/watch?v=rsd4FNGTRBw&t=1449s) Good luck!
    Marked as helpful
    0
  • Jonathan•295
    @Nathan-FrontPosted about 3 years ago

    Hello Hassan! Congrats on your submission. As a fellow beginner in HTML and CSS couple of things I would like to share:

    1. Rather than using a divs inside the <ul> you should use <li> instead, try this link for more reference about list in HTML >> https://www.w3schools.com/html/html_lists.asp
    2. Your page is missing an h1. For accessibility reasons, pages require one h1 element. In your code you used h2 even though no h1 can be seen, h1 should not be skipped. I recommend you insert h1 then try to hide it using css to fix the accessibility issue. Try this site to learn more about accessibility in html >>>>https://webaim.org/techniques/css/invisiblecontent/
    3. You don't need vertical scrollbar because site should be landing page
    4. Try fixing the background-image in mobile view, in the challenge it should be on top of the screen during mobile view. Try experimenting on background size using cover and contain during desktop view and mobile view to see the difference.
    Marked as helpful
    2