@betty-papSubmitted over 1 year ago
Latest solutions
Latest comments
- @NKoshmakPosted about 1 month ago
Good job! But there is couple moments to improve for better responsiveness: Keep .result-summary width: 100% for flexibility. Use 1 column layout until 768px, then switch to 2 columns. Ensure .result-card and .summary-card don’t shrink below 250px. Adjust padding for small screens to prevent excess shrinking.
0 - @NKoshmakSubmitted 3 months ago@NKoshmakPosted 3 months ago
Thank you! The delay I made via setTimeout() function.
1 - @Benson0721Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I have more confident about doing these front-end project! Maybe after doing more prastise later, I can use those experience to help myself to build my website!
What challenges did you encounter, and how did you overcome them?In this practice, the layout part wasn't too difficult for me. The main challenge was form validation; it took me some time to figure out how to implement it. I spent some time developing the validation logic myself, but formatting validation was quite a hassle. Therefore, I decided to use a library called "React Hook Form" to become more familiar with it. Completing this project required using React state concepts, which weren't too challenging in this context.
What specific areas of your project would you like help with?The more convenient way to build React in this project thx~
@NKoshmakPosted 3 months agoThe code is functional, scalable, and well-written overall.
Marked as helpful1 - @Moayad18Submitted 3 months ago@NKoshmakPosted 3 months ago
Good job! But I have a couple suggestions on how you can improve your code, which you might find useful: 1. Some class names, such as .image, .container, .info, and .share, are too generic. More descriptive class names, like .main-image, .content-container, .info-wrapper, or .share-button, would make the code self-explanatory. 2. Such deep nesting 'main .container .info .name span' can make CSS harder to maintain and is prone to breakage when restructuring HTML. Instead, add meaningful class names to avoid relying on structure. It would be useful to get familiar with the specificity of selectors and how it impacts code.
Marked as helpful0 - @nabinsth36Submitted 3 months ago
- @m-abubakr1Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Found and Practiced some new Tricks of CSS Like 2 line code for centering the content using grid system, Display:grid; place-content:center;
@NKoshmakPosted 4 months agoWhile your code is well-organized and functional, there are areas which could be improved: you have an inline for the attribution section. While this isn’t a major issue for small projects, for maintainability and performance, it’s better to keep all styles in the external style.css file.
Marked as helpful1
