Skip to content
OverviewSolutions
11
Comments
7
Mzu Soci
@Mzu-Soci

All comments

  • Mzu Soci•170
    @Mzu-SociPosted about 2 years ago

    Hi

    Is there any particular reason you chose to use both inline and external css? The styles applied on your img in the html documents can be declared on the css doc.

    I think having all styles on one document makes it easier to manage the changes required in future and leans closer to best practice.

    I hope this helps.

    0
  • Mzu Soci•170
    @Mzu-SociPosted about 2 years ago

    Hello Ahmed Samy

    I tried to view your project on my mobile and it looks broken please check using your phone.

    On your html please add the alt="" attribute to your image tag.

    You might also have to wrap your attribution div with a footer tag. The same might be required for div main try wrapping it with<main></main>

    You can do some reading on the requirements of landmarks here https://dequeuniversity.com/rules/axe/4.3/region?application=axeAPI

    I hope this helps

    1
  • Mzu Soci•170
    @Mzu-SociPosted about 2 years ago

    Hello

    Your .box border radius is too aggressive try to get is closer to the same setting as your image border radius.

    Your heading don't size is too large, if you decrease the size to medium could help.

    The paragraph font color needs adjusting to match the style guide, also adjust the line height to give more space.

    I hope that helps.

    Marked as helpful
    0
  • Mzu Soci•170
    @Mzu-SociPosted about 2 years ago

    Hello rahul3d2y

    I would recommend you remove the h3 tag for your Sign Up button, it's not necessary. It must look like this <button>Sign Up</button>. A button is supposed to have a label not a heading. For more reading on the subject please visit W3Schools - https://www.w3schools.com/tags/tag_button.asp

    I hope that helps :)

    0
  • Amber•10
    @amb179Submitted about 2 years ago

    How can I make the code more responsive?

    QR Code

    2
    Mzu Soci•170
    @Mzu-SociPosted about 2 years ago

    Hello Amber

    To make your site more responsive I would suggest you take a look at Kevin Powell's course on responsive web design, here is a link - https://courses.kevinpowell.co/conquering-responsive-layouts. It's free.

    His approach suggests getting the simple items like max-width and max- heights correct.

    Marked as helpful
    0
  • Oluwatobi•160
    @Oluwatobi9034Submitted about 2 years ago

    Hi, i just finished the 3-column preview card component, it is a mobile first responsive design, please give me any feedback that could improve my code. Thanks

    3-column preview card component

    1
    Mzu Soci•170
    @Mzu-SociPosted about 2 years ago

    Hello Aluwatobi

    There are 2 items that will need some attention on this project. First you have to add the alt="" attribute to your image tags, this will remove the errors you are getting on your report. Second item will be the text color of your buttons, each button's text color must match the color of the column that contains it.

    I hope that helps :)

    1
  • Mzu Soci•170
    @Mzu-SociPosted about 2 years ago

    Hello Anastasios

    The resource that assisted me to understand how to make my sites responsive is Conquering Responsive Websites by Kevin Powell. The course is free on this link - https://courses.kevinpowell.co/conquering-responsive-layouts

    His approach to guaranteed responsive sites starts with understanding how to set the widths and heights of all items on your page.

    Marked as helpful
    0