@JimmyHoang296Submitted 9 days ago
P
Mukarram Haq
@MukarramHaqAll comments
- @MukarramHaqPosted 2 days ago
I'm definitely looking at your code and making mine better, haha. Amazing solution!
0 - @JimmyHoang296Submitted 9 days ago
- @MukarramHaqSubmitted 12 days agoWhat are you most proud of, and what would you do differently next time?
Learned about max-height and overflow hidden in a better way, haha. Also, learned another use case of the forEach loop.
What challenges did you encounter, and how did you overcome them?It was definitely trying to hide the answer and how to show it.
What specific areas of your project would you like help with?If anyone can take a look at my JS code and critique it? I know it can be improve just wanted to know what y'all think.
- @JimmyHoang296Submitted 13 days ago@MukarramHaqPosted 12 days ago
That's a pretty good solution. Loved how you handled the JS code. Something that I can learn from. Good stuff :)
0 - @said-opsSubmitted 4 months ago
- @Si1entERASubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
The completion of the project.
What challenges did you encounter, and how did you overcome them?- Refactoring code.
- Trying to use the DRY principle.
- Custom input field.
Any and all feedback is welcome. I also plan on going back to my previous projects to practice refactoring code.
- @satryandiSubmitted over 1 year ago@MukarramHaqPosted 5 months ago
I really have nothing to add.
Your JS code is perfect
I'll look into it and make my JS code better haha
Good stuff!
0 - @SaimgkdnSubmitted 5 months ago@MukarramHaqPosted 5 months ago
Hey, Saim! That's a good solution. I do have some recommendations:
- When you hit the dismiss button, it should go back to the original sign up site
- Try and show the email address you entered in the second site. You can try using
localStorageto do that
0 - @tortarugaSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud to have completed the challenge, but I think there was a simpler way to do it
What challenges did you encounter, and how did you overcome them?javascript didnt work on the live website, but it got fixed by adding a dot before the file path
What specific areas of your project would you like help with?any critique is welcome
@MukarramHaqPosted 5 months agoGood job, bro
I have a question? How did you stop the image from stretching? If you look at my project, it stretches and looks ugly. I would appreciate some help with that
0 - @surpoxiaSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I think I came pretty close. Some letter spacing or a font-size here or there might be slightly off, but other then two my major flaws, I should have gotten it mostly right.
What challenges did you encounter, and how did you overcome them?My two biggest problems where:
1.) The size of the cards and how they are exactly ordered and spaced out on the grid in the MockUp. If you look at the very bottom of my CSS-file you can see my grid area for the desktop view using an excessive amount of colums and rows. However, that was my only solution to get the size and spacing of the cards as close as possible to the actual spacing and sizing of the MockUp.
2.) In the MockUp you can see that the paragraph of the card to the far right card (Kira Whittle) uses a slightly different gap size between it's headline and it's paragraph and is probably meant to adjust dynamically. I tried everything from grids to flex for that, but just could not get it to work for me.
What specific areas of your project would you like help with?Maybe someone knows a better solution to my two problems. Or if you notice anything else, please let me know.
@MukarramHaqPosted 6 months agoLove it. Good job on this one :)
For your first problem:
I would suggest looking into how to span an element across different columns and rows. You can use the
grid-columnorgrid-rowwhich is the short hand forgrid-column-startandgrid-column-endAnother thing that really helped me with this project is using
grid-template-columnproperty. For this to work you need to figure out how many columns do you need in this project which is usually the most difficult thing to do if you are starting out. For that I would suggest drawing out the layout on a piece of paper and try to work out how many columns you need. I generally do not declare rows unless I really have to and for this project you just need to declare columns which you can usinggrid-template-columnlooking into it might be a good idea. This will save you a lot of headacheI hope this was helpful for you :)
Marked as helpful1 - @mussiehSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Didn't use a CSS framework
What challenges did you encounter, and how did you overcome them?No big challenges.
What specific areas of your project would you like help with?I would like feedback on my project if I made a mistake.
- @kirti253Submitted 7 months ago@MukarramHaqPosted 6 months ago
Hey, great work!
I would like to point out a few things:
HTML:
- In your
<body>put everything inside the<main>tag for this particular project. It specifies the main content of the page. - Always have something in you
altfor an image. You can say something like Chanel Parfum <br>tags should be avoided write the whole sentence in one line.- In your
<button>tag you can give the source of the SVG that you downloaded with this project it should beimages/icon-cart.svg
CSS:
- In
.imagenever use px for width. Always yourrem. - The
font-sizeshould never be inpxuseremfor that as well - In
buttonremove the borders byborder:none.
This is all I could help you with with my limited knowledge. I hope you find this useful :)
0 - In your
