Skip to content
OverviewSolutions
4
Comments
2
Muhaddis Rehman
@MuhaddisRehman

All comments

  • Udeme01•200
    @Udeme01Submitted over 1 year ago

    i found the dropdown MENUs a lil difficult and the JS part since i'm new to learning JS but I understood my JS code though... Unsure of the dropdown menu area...

    flexbox, aria attributes, etc...

    1
    Muhaddis Rehman•100
    @MuhaddisRehmanPosted over 1 year ago

    First of all Congratulations for completing this challenge🎉🎉

    The things you could improve are:

    -Make transitions a bit faster especially the dropdowns.

    -Instead of adding border to the buttons on hover add them in their normal state It's because the addition of border on hover causes height and width difference which cause things to shift every time on hover

    Overall it's great👌

    Good Luck and Happy coding😊

    Marked as helpful
    0
  • Muhaddis Rehman•100
    @MuhaddisRehmanPosted over 1 year ago

    For button state you could just add the border on normal state and just change background on hover that way the button won't cause the height difference you get with and without border. A little transition also makes things visually smooth.

    .card-button {
  border: 1px solid var(--very-light-gray);
  background: var(--very-light-gray);
  padding: 1rem 2rem;
  border-radius: 30px;
  cursor: pointer;
  color: inherit;
  transition: all 0.3s ease;
}

.card-button:hover {
  background: inherit;
}```
    Marked as helpful
    1