@PryceIsRightSubmitted over 2 years ago
ANY feedback would be appreciated!
Mubeen Shaikh
@MubeenAhmadShaikhAll comments
- @MubeenAhmadShaikhPosted over 2 years ago
Looks good, you can add h1 tag instead of h3 for that accessibility issue.
Marked as helpful1 - @justsomeletterSubmitted over 2 years ago
I tried my best but couldn't get a hold of how to make it responsive. Can you guys direct me to some resources for learning it?
@MubeenAhmadShaikhPosted over 2 years agoLooks good I have following feedbacks for you,
- you can use flexbox instead of margin:auto for aligning the card in center. You can refer this Flexbox guide
- And for responsive site you can refer Beginner's guide to media queries
If you get stuck checkout my solution. Hope this helps you
1 - @moheb2000Submitted over 2 years ago
I reduced opacity for cyan active state of image. I want to set full opacity for eye viewer in center of image but I can't. Any advice?
@MubeenAhmadShaikhPosted over 2 years agoGood work MOHAMMAD EBRAHIMI,
You can add your svg icon z-index of 2 it will be then displayed on top
Hope this helps you :)
Marked as helpful0 - @zastar23Submitted over 2 years ago
Took me a while to complete this one, especially the grid part but I think it is looking good.
Any feedback is welcome!
@MubeenAhmadShaikhPosted over 2 years agoThe grid part is actually challenging. I have following suggestions for you:
- The transform and stand out text content is aligned to the center you can align them to left.
- The graphic and photography images are of mobile view, you can change them to desktop images using media queries with background property.
you can refer my solution but I would suggest only if you get stuck.
0
