justinrieman• 30
@justinrieman
Submitted
Mohammed Hassan
@MrMohammedMath
All comments
- Mohammed Hassan• 240
@MrMohammedMath
Posted
Hello and congratulations about finishing your first challenge I have some suggestions that I thought it will be helpful.
- make sure to have at least one
<main>tag. you can use it instaead of div with class container Note: this will remove the "All page content should be contained by landmarks" warning - try to make
.card-containertake the full width and height usingwidth: 100%; min-height: 100vh.
Marked as helpful
0 - make sure to have at least one
@Eduardo-Marque-s
Submitted
Mohammed Hassan• 240@MrMohammedMath
Posted
Hello @Eduardo-Marque-s Congratulations on successfully completing the challenge
I have some recommendations regarding your code that I believe will have a great interest to you.
HTML:
- try putting card component inside a
<main>element to reduce the number of reports.
CSS
- try to make all your css selectors by classes since it make a clear view.
I hope you find this helpful
Marked as helpful
0- try putting card component inside a
- amirbek887• 30
@amirbek887
Submitted
Mohammed Hassan• 240@MrMohammedMath
Posted
I suggest to use justify-content: center; align-items: center; in your grid container class
0 - AntoineReibel• 40
@AntoineReibel
Submitted
Mohammed Hassan• 240@MrMohammedMath
Posted
Good job AntoineReibel but you need to take responsive design in consider I tested your component on Samsung Galaxy S8+, and the design is not true my suggestion is to build for mobile first then use min-width: 768px for desktop
1
