Just one question : How can I do the shadow under the cards?
I'm open to any other suggestions to improve my code ! 😃
Just one question : How can I do the shadow under the cards?
I'm open to any other suggestions to improve my code ! 😃
there is a property call box shadow. with that you will be able to bring shadow to your design.
yourcard {
box-shadow: 5px 10px rgba(255,255,255,.1);
}
i hope this might helped you
I'm lerning about flexbox these days, so I choosed to apply this properties here. The mobile version was not exact the same as the example, I set the width and the height in% to do the trick, but I'm not sure if it's the best way. If anyone could show me a better way, I'd appreciate.
you are specifying height for the grid so it will not be able to grow according to the content. if you remove the height from grid class it will fix the issue . remove height form grid class in media query also it will fix the issue for mobile. it will be responsive.
use html for structure CSS for styling js for functionality
don't use inline CSS it is not best practice. there are many things need to be changed..
I tried my best coding this website, I tried to make it responsive as much as I can, if there's anything you can help me with or advices, tips, etc. Everything will be appreciated, thank you.
button should have some padding so that it have space around the text. And in super charge workflow section the one image is missing from the center div . font size is big for paragraph. there should be some spacing between image and content. over all nice job.
suggestions are welcome thanks
media query need to be adjusted because you are not using device screen space properly. even in the 1366px it goes to mobile design.
nice job, hover state are missing. if it is there it will be nice.
There is something wrong with the GitHubpages configuration because the images won't load. Could someone help me with this problem?
image will show in live server but when u access the site without the live server the image will not load. to fix this issue remove "/" from the starting of image source. your code: <img src="/images/illustration-hero.svg" alt="Music Hero">
use this where "/" is not in starting of source.
<img src="images/illustration-hero.svg" alt="Music Hero">Hey guys, I'd really appreciate your criticism and review of this landing page I made using HTML and Vanilla CSS.
footer section need some improvement. and the links in the footer as so left. Sticking to the edge.
Any feedback on my work would be highly appreciated. Thanks!
why us section is not para it is a list. you can make it similar to design by making it as list. nice job on overall design.
Still not happy with the final result. Some feedback to improve will be appreciated
nice job. you can see that the 3day left is taking new line. you can fix this by removing ul in the sub2 and making it as display flex. this code will help you to align items.
ie) in html
<div class="sub2"> <div class=""><img src="images/icon-ethereum.svg" alt="">0.041 ETH</div> <div class=""><img src="images/icon-clock.svg" alt="">3 days left </div> </div> css style:.sub2{ display: flex; justify-content: space-between; align-items: center;
}
it will be aligned in one line and you can give some margin for the image. so the is little space between image and text.
Hi, developers please provide any feedback it will be helpful for my learning.
@skyv26 can you suggest best recourses for grid for learn . I am having some doubt
id must be unique, don't use same id for multiple element. it is not best practice use class instead of id.