Mohtashim Ali
@MohtashimAli85All comments
- @asmaa-elfatayrySubmitted about 2 years ago
- @AditNovadiantoSubmitted over 2 years ago
I will be happy to hear any feedback and suggestion!!!
- @buneeIsSloSubmitted over 2 years ago
Hi! Here's another challenge I've completed to get better React.
I'm still not at a point where I can comfortably create a solution all by myself(with React), I had to study this solution. Please feel free to let me know about any mistakes that I've made.
- @salaam51Submitted over 2 years ago
Suggestions are welcome
@MohtashimAli85Posted over 2 years agoKindly resolve the accessibility issues. Other than that Its great and just fix the bg colors to match the design.
0 - @asmaa-elfatayrySubmitted over 2 years ago@MohtashimAli85Posted over 2 years ago
I reviewed your code and website both are good. but the background images position you need to play with values to set them ig. Over all you doing great. :)
Marked as helpful0 - @Isgomes7Submitted over 2 years ago@MohtashimAli85Posted over 2 years ago
The things I noticed
- To make body take full height give body and html tag height 100%
html,body{ height :100%}
- Learn grid you can easily center a div with it like this
main{display:grid; place-items:center; }
- And its static the daily, weekly buttons don't work. Also share the repo to review your coding. Happy coding :)
0 - To make body take full height give body and html tag height 100%
- @AditNovadiantoSubmitted over 2 years ago
I will be happy to hear any feedback and suggestion!!!
@MohtashimAli85Posted over 2 years agoFrontend Looks great! But the code I think is messy. It can be a lot of simpler. I think you did it for learning but I would like you to make it as simple as you can! happy coding :)
Marked as helpful0 - @AditNovadiantoSubmitted over 2 years ago
I will happy to hear any feedback and suggestion!!!
@MohtashimAli85Posted over 2 years agoLooks Great. I think it's time for you to start higher level projects.
Marked as helpful1 - @buneeIsSloSubmitted over 2 years ago
Hi! It's been a good minute since I posted a solution on here. I have been teaching myself ReactJS and wanted to create a small project so, I chose to solve this newbie challenge for some practice.
However, I was unable to complete this challenge on my own. Thanks to this solution I realized where I was going wrong and managed to create my solution.
I have no questions for this one, but I'm open to any tips and feedback you have for me :)
@MohtashimAli85Posted over 2 years agobtw can you give tips regarding seamless animations and anything else :3
0 - @buneeIsSloSubmitted over 2 years ago
Hi! It's been a good minute since I posted a solution on here. I have been teaching myself ReactJS and wanted to create a small project so, I chose to solve this newbie challenge for some practice.
However, I was unable to complete this challenge on my own. Thanks to this solution I realized where I was going wrong and managed to create my solution.
I have no questions for this one, but I'm open to any tips and feedback you have for me :)
@MohtashimAli85Posted over 2 years agoLoved the animation part <3 Also code is clean !
1 - @AditNovadiantoSubmitted over 2 years ago
I will be happy to hear any feedback and suggestion!!!
@MohtashimAli85Posted over 2 years agoNeat ! Other than that I would recommend you to make components which you did, but make more. Try to breakdown the website layout into proper components. It will help you a lot. For example Navbar component HeroSection component Banner component also instead of footersection name i would recommend just footer Though In the end we just see the output. But following these will definitively ease you. These are just my opinions. Enjoy coding
Marked as helpful1 - @Mahad410Submitted over 2 years ago
Gimme some feedback....!
@MohtashimAli85Posted over 2 years agolearn about transitions Say we have a anchor tag whose color changes to red on hover for this /CSS Transition Syntax/
selector { transition: property duration timing-function delay|initial|inherit; } a{ transition: color 0.2s ease-in; } a:hover{ color:red; } div:hover { background-color: #000; transition: background-color 400ms; } /* Or control over animation with transition timing */ div:hover { background-color: #000; transition: background-color 400ms ease-in-out; }
1