vetaprog85samir• 10
@vetaprog85samir
Submitted
Mohamed Mostafa
@Mohamedmostafa808
All comments
- Mohamed Mostafa• 30
@Mohamedmostafa808
Posted
welcome. Congratulations on successfully completing the first challenge! 🎉
- I have other recommendations for your code that I think will be of great interest to you.
HTML 🏷️:
-
This solution generates accessibility error reports due to non-semantic coding
- <html> element must have lang attribute with valid value, so fix it by <html lang="en">
-
So fix it by replacing the <div class="base"> with the <main> semantic element to improve the accessibility and organization of your page.
-
And you can specify width for h1 text with image size in css file. This is to show the design closer to the one in the challenge
I hope I helped you! 😀 First of all, the solution you provided is awesome, And don't let anything get you down
Happy coding!
0
