@Tarek514Submitted about 2 months ago
Mohamed khlifi
@Mohamedkh369All comments
- @Mohamedkh369Posted about 2 months ago
congratulations for finishing this challenge , the result looks good , even though there are a few things that are diffirent from the design provided , i suggest you try to make them look like the design , it gives challenges that really ehlp u learn new things , again congratulations for finishing the challenge , nice work and good luck in the next challenges.
0 - @ToprakPehleeoneSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
It was a good practice for using grid layout and 'grid area' properity.
What challenges did you encounter, and how did you overcome them?Making column widths as requested from the challenge was a bit challenging. I tried different values and found the solution.
What specific areas of your project would you like help with?I gave the 'grid-template-colums' some values in 'rem'. So my project is technically not fully responsive. If you have any ideas on how to make this project look exactly like the challenge without using fixed values for column width, i am open to suggestions.
Thanks in advance. :)
- @mohammedsabSubmitted 3 months ago
- @Cristal32Submitted 3 months ago@Mohamedkh369Posted 3 months ago
hello , congratulations for finishing the challenge , the result looks pretty good , however i would like to point that the live site preview doesnt work, as well as the repository link , i suggest that you fix this issue so that you can get helpful feedback from the community . good luck on your next challenge.
Marked as helpful0 - @ameencodingSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
To me this challenge was easy and simple.
What challenges did you encounter, and how did you overcome them?Nothing fence, everything was easy.
- @okeyifeaSubmitted 3 months ago@Mohamedkh369Posted 3 months ago
Hello , first congratulations for finishing the challenge , you did a great work ! though i would like to point something for you , as you might have noticed, the card is not vertically centered in your page even though you applied the display : flex and the align-items:center on the body element , this issue could be resolved by simply adding "height: 100vh" property to the body element which is the parent element of the container div , if it has no specific height declared the flex container will have no specific height itself , it will be as tall as it's content , in this case the card is is taking the full height of the parent flex element(the body element ) which is why it doesnt appear centered . i hope this information will be useful to you andcongratulations again for finishing the challenge , good luck in the next one .
Marked as helpful1
