Skip to content
OverviewSolutions
7
Comments
2
Misaponce
@Misaponce

All comments

  • Damian Marut•10
    @MarutovskySubmitted over 1 year ago

    Hi!

    1. Is it ok in this case to use html elements in my css file instead of using classes?
    2. What with the mobile design? I didn't do nothing to get it, but when I resize the screen it looks good.
    3. I'm curious about the way I pushed footer to the bottom of the page.

    Feel free to leave any feedback, thanks!

    QR Code first solution

    2
    Misaponce•170
    @MisaponcePosted over 1 year ago

    Hi Damian your solution looks good, is pixel perfect 💯

    In my opinion it is ok to use CSS element selector since it is one of the ways to achive that, you can also use ID and Classes selector either one or the other is fine.

    I think using semantic HTML is what did the mobile design easier and to get the footer all the way to the bottom, try using margin-top: auto on the footer element

    Marked as helpful
    0
  • Misaponce•170
    @MisaponcePosted over 1 year ago

    Hi there, your solution looks good, by looking at your code I can see that the opening "<body>" tag is missing and I can also see that you are using flex box to align the elements which is one of the best ways to center elements.

    To build a responsive design more efficiently you can use tools like Bootstrap or Tailwind which are CSS framework mainly focus on mobile-first design.

    👍👍👍

    Marked as helpful
    1