@DarkKiller31Submitted 4 months ago
P
Bred
@MirrorIceAll comments
- @MirrorIcePosted 4 months ago
- Pay attention to list margins -> I think yours were a little bigger than they should be
- The "Preparation time" list and the table could use a bit of work -> for example, you could play with the boldness of the elements to match with what's in the initial design
- There is a small discrepancy in distancing between the title and description
0 - @paramaguru077Submitted 4 months ago@MirrorIcePosted 4 months ago
Looks very neat! Here are some improvements that would help your project look better:
- The font looks different from what is from the original design, also looks for the sizes to be in the ballpark
- Pay attention to the font weights, especially on the social links
- Make sure there is a consistent spacing between the individual blocks (image, name/location, quote, social links)
0 - @candebermejoSubmitted 5 months ago@MirrorIcePosted 5 months ago
Hello,
The solution looks nice and neat, but the image is not visible for some reason. It might be a good idea reviewing that.
Containing children by selectors, instead of selecting the identifiers, though nice, might hinder remembering which styling is which in the long term. So you could use more ids and classes in your HTML file, to leverage your CSS code.
Also consider a standard font-size in which you could derive your rems. In this project, it was roughly 16px on desktop screens and 14px on mobile.
0 - @Control222Submitted 5 months ago@MirrorIcePosted 5 months ago
The code looks really nice, don't have anything much to the structure.
I think the only thing worth mentioning is that the padding on the image (and maybe on the text) is a bit off. You put it as 1 rem with a base of 15px, but the padding itself is 16px.
The image corners have too much of a radius (1 rem -> 15 px instead of 10px). There are rem to px calculators online, so maybe that can help you if you want to keep using that unit.
The title font should be grayish blue instead of black.
0
