@Stephanie0905Submitted 5 months ago
P
MichelleP1
@MichelleP1All comments
- @MichelleP1Posted 5 months ago
Nice job! It might be good to put some of the sizes into variables like you have with the colors so they can be reused. Also if your IDE allows extensions Prettier could help with code formatting by reformatting the file every time you save.
Marked as helpful0 - @radriann21Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?
The project had been completed a long time ago. But ihad not been able to share the solution.
I am proud to be able to do these types of projects, it is getting easier and easier.
What challenges did you encounter, and how did you overcome them?No particular challenge
@MichelleP1Posted 5 months agoLooks really good. The only thing I could think to do different is maybe use some more variables for sizes, like you do with color.
1 - @teuthixSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I was most proud of figuring out how to get the qr code centered in the middle of the page. I think it gave me a better understanding of justify-content versus align-items and how to use them.
What challenges did you encounter, and how did you overcome them?Figuring out how to center the qr code vertically was challenging. It involved some googling and rereading how flexboxes work.
What specific areas of your project would you like help with?If any of my code doesn't follow best practices, I would love to know how to improve my code in that way.
@MichelleP1Posted 5 months agoNice job. One thing I noticed is that you have .attribution and .atribution a separated. If you want, you could combine them like this:
.attribution { a { color: hsl(228, 45%, 44%); } }
0
