@T-Gomziakov
Submitted
Hello! This is my first solution and would appreciate any feedback people have.
@MatejBumbera
@T-Gomziakov
Submitted
Hello! This is my first solution and would appreciate any feedback people have.
@MatejBumbera
Posted
Hi, first of all, congratulations on your solution! You did a great job in matching it to the design and I really like your code too. I just think you have some excessive code there.
The excessive code I mean is assigning classes to main, h1 and p tags. I think you could easily just style directly the main, h1 and p tags.
Another thing I noticed is that you used picture tag around img, and I'd say that's not necessary since the picture tag is used when you want to put there multiple images that change in response to screen width. You can look up more about the usage of picture tag here: https://www.w3schools.com/html/html_images_picture.asp
And one tiny thing I noticed is u used article tag, which is very good since it's semantic, but I wouldn't really use it here since article should be used on part of a webpage that should be independent, like u could just put it on a different webpage and it would make sense. I would replace it with section, which is also semantic. You can check the difference at: https://www.w3schools.com/html/html5_semantic_elements.asp
Overall, you did a great job and I wish you happy coding! I hope you find my review helpful :)
Marked as helpful
@ribeiroLevi
Submitted
I am having a realy bad time trying to match the resolution of my version to the resolution of the design. any tips?
@MatejBumbera
Posted
Hi, I don't have the answer to your question, but I have some tips regarding your solution. First of all, congratulations on your solution! You did a great job in matching it to the design. Now to the tips:
But overall, good job and keep coding! I hope you find my review helpful :D