Skip to content
OverviewSolutions
3
Comments
2
P
Margaux Armanet
@MargauxArmanet

All comments

  • Margaux Armanet•50
    @MargauxArmanetPosted 5 months ago

    Hi there!

    I’ve taken a look at your project, and I’m really impressed with your efforts. I have a few suggestions that might help improve it even further:

    For index.html:

    • Consider using semantic tags: Using elements like <article>, <figure>, and <figcaption> can improve accessibility and SEO.

    • Setting default width and height for images: It can be helpful to set these attributes on your images to ensure they display correctly, even if your CSS doesn’t load for some reason.

    • Making the blog preview card clickable: If you wrap your .container-main in an a tag, it makes the whole card clickable. To style the title so it changes color on hover, you can try adding this CSS rule: a:hover h1 { color: yellow; }.

    For main.css:

    • Using a mobile-first approach: Especially for this challenge, it will make your life so much easier.
    • Applying media queries: They allow you to style your site differently depending on the screen size.

    These are just small ideas but I hope you find them useful!

    0
  • Egotanwa Favour•10
    @AnonymousVigoSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    I would like to use SCSS for my styling

    What challenges did you encounter, and how did you overcome them?

    I didn't make use of the figma file, so it was hard to get the elements size correctly

    What specific areas of your project would you like help with?

    none

    I made use HTML and CSS

    1
    Margaux Armanet•50
    @MargauxArmanetPosted 5 months ago

    Hi,

    I hope you don't mind me reaching out. I really like the effort you put into your solution!

    I saw that you mentioned not using the Figma file, so I thought I'd share a few details in case they're helpful:

    • The image size should be exactly 288px by 288px.
    • The .qr-card dimensions are 320px in width and 497px in height.
    • There should also be a box-shadow on the .qr-card.

    If you don’t mind, could you take a quick look at my QR code solution? I'm having some trouble with the styling of the p element and would really appreciate your guidance.

    Thank you!

    Marked as helpful
    0