All comments

• 

  Javaled• 30

  @Javaled

  Submitted about 2 years ago

  What did you find difficult while building the project? Responsiveness and image size. Which areas of your code are you unsure of? Image size. Do you have any questions about best practices? How to use less code.

  

  QR code component

  1

  20

  

  manny-munoz• 60

  @Manny-Munoz

  Posted about 2 years ago

  Hi Javier, first of all congrats on finishing the challenge, a really good job in my opinion!

  I do believe that some part of the coding could had done better.

  • First I noticed that you added a media query, I would suggest when it comes to font-size, there are other alternatives like the css function clamp(), but in this particular challenge I would sugggest only use the default font-size.

  • I also noticed that you added font-weigth: 700 to an h1 that it's a little bit of a boilerplate because the h1 elements are already on 700.

  • I would also suggest to use a css methodology like BEM if you want your code to be reusable.

  • I also noticed that there is a typo on your code. There is a 1.6drem instead of 1.6rem.

  .card-text-desc {
          font-size: 1.6drem;
      }
  } 
  

  Here are also some tips that you can use to write less code:

  • Keep your solution simple trying to avoid any additional media query
  • Refactor ( Read your code and improve it if it's possible)
  • Keep learning and learning, It could be a little bit cliché but keep coding it's the easiest path to be able to get experience and find a better solution easily, so keep coding and you will get better.

  That's it! I hope this helps!, Happy coding!

  Marked as helpful

  0