I would be happy for any feedback! Thank you :)
Mohammed Majd
@MajdMohammedAll comments
- @aggie-lSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?@MajdMohammedPosted 6 months ago
I like your solution, It's short and pretty close to the design.
Some feedback:
- You could give your HTML structure a meaning by using Section, Blockquote with two P inside for the quotes.
- It's better to use rem for media queries, because px doesn't scale well with user preferences for larger text sizes.
I hope you find this useful. Happy coding!
Marked as helpful1 - @ArcloanSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?Setting the right dimension for the main container.
What specific areas of your project would you like help with?If anyone has any suggestions in general or regarding the sizing of the main box, that of the element, it will be really appreciated. Thank you :)
@MajdMohammedPosted 6 months agoSome feedback:
- I noticed that you don't use semantic elements, it helps the browser to understand better your HTML structure.
- h1 instead of h2 will be nice for a proper HTML structure.
- The font size is too different than the font size on the design given, try to set an accurate font size
- For the headers inside the cards try to use h2 instead of div, to give your structure a meaning
- sometimes using main as container and section as child container is way better than using div.
- your shadow box looks too different, it needs to be a bit closer to the design
I hope my feedback is useful Happy coding !
Marked as helpful1 - @omlan99Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Can not think of anything right now. Any suggestion will be appreciated.
What challenges did you encounter, and how did you overcome them?Nothing as such.
What specific areas of your project would you like help with?I had approached for mobile design first and used rem as unit this makes mobile version accurate to design but faced difficulties on desktop version to be accurate.
@MajdMohammedPosted 6 months agoNice work, But I noticed that the button element is no longer having full width when resizing the screen.
1 - @booirngSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
learning about positions and psudo elements . Semantic html.
What challenges did you encounter, and how did you overcome them?creating bullet points and number listing with default color. That was challenging for me. OpenAI helped me solve that as always.
What specific areas of your project would you like help with?responsive html and css layout and creating layout with flexbox.
@MajdMohammedPosted 6 months agothe design is not responsive, as the nutrition list, and some other elements.
0 - @Amit-MahiSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
working with padding and margin.
What challenges did you encounter, and how did you overcome them?working with Links and text decoration
What specific areas of your project would you like help with?overall was fine. any good practices would help.thanks
@MajdMohammedPosted 6 months agoHey, I am a beginner too but I have some advice.
Some feedback:
- Use a list for the links.
- Try to not use width in percentage
- this challenge does not need media queries for a responsive design
0 - @fish-ladderSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I'm most proud of feeling more comfortable with Flexbox and not needing to look at the documentation so much to achieve the layout I was after.
Next time I will add font-sizes in rems as custom properties in :root to make text scaling easier.
What challenges did you encounter, and how did you overcome them?-
I thought I had completed the challenge and then realized the font sizes were different in desktop vs mobile layout (should have read the instructions more closely). I needed to revisit my font-size units in order to scale them for the different display sizes.
-
Using Flexbox and auto margins to horizontally and vertically center the main card worked great except that it shoved the attribution element out of view at the bottom of the page. I fixed this by applying auto margins to the attribution element as well.
How can I better organize my CSS code to make it cleaner?
-
- @Aniket0147Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Nothing
What challenges did you encounter, and how did you overcome them?I encountered some problems with CSS. To overcome that, I watched the videos related to CSS.
What specific areas of your project would you like help with?feedbacks are welcomed
- @MajdMohammedSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that I could clown the project, not 100% as the original but at least I made it look decent.
What challenges did you encounter, and how did you overcome them?One of the challenges is trying to understand what tools have been used for the original project, and how I can provide the same quality with a responsive design. I also learned new technics for styling lists and tables.
What specific areas of your project would you like help with?I believe I need to enhance my responsive design skills, and I'm curious if it's possible to code the same page using fewer lines of code. If there's any way I could have done it better, please let me know. Thank you!
@MajdMohammedPosted 6 months agoHello @grace-snow,
Repo is updated:
- padding percentage replaced with clamp().
- main font-size is now changed to clamp() to stay flued with the container.
- table elements are changed to th and td.
- fixed some slight differences with the elements margin.
Please re-check the repo when you have the time. Thank you !
0 - @MajdMohammedSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that I could clown the project, not 100% as the original but at least I made it look decent.
What challenges did you encounter, and how did you overcome them?One of the challenges is trying to understand what tools have been used for the original project, and how I can provide the same quality with a responsive design. I also learned new technics for styling lists and tables.
What specific areas of your project would you like help with?I believe I need to enhance my responsive design skills, and I'm curious if it's possible to code the same page using fewer lines of code. If there's any way I could have done it better, please let me know. Thank you!
@MajdMohammedPosted 6 months agoI think now i completely understand the flaws with using percentages, But if I still remember, when I use rem i also encounter same issue with styling. But I trust your judgement I will never use percentage in padding again !. Next time when i have the opportunity i will fix the font-size plus the table html.
Have a good day mam.
0