@HamptooonSubmitted 2 months ago
Marcin Mikos
@M-MikosAll comments
- @M-MikosPosted 2 months ago
Hi! Thank for your solution, let me share some tips :
- Semantic HTML: Since buttons are similar, repetitive elements next to each other, you could consider tagging them in
<li>
tag, wrapped in<ul>
parent element. - Sass file structure: You may be interested in implementing elements of the 7-1 pattern in your project, in order to more clearly structure your .scss files (https://sass-guidelin.es/#chapter-architecture)
- Units: Using REM units to specify all dimensions (except very small dimensions such as border-width: 1px) is considered a good practice because of the ease of implementing responsiveness. With REM units, all you need to do is change the font-size value of the root element (html element), and all dimensions dependent on these units will automatically scale. (https://www.freecodecamp.org/news/css-units-when-to-use-each-one/)
Good luck in your future work!
0 - Semantic HTML: Since buttons are similar, repetitive elements next to each other, you could consider tagging them in
- @PetrakoowSubmitted 2 months ago@M-MikosPosted 2 months ago
Hi! Good work, I like your usage of CSS clamp() function. Let me share some tips:
- Units: Using REM units to specify all dimensions (except very small dimensions such as
border-width: 1px
) is considered a good practice because of the ease of implementing responsiveness. With REM units, all you need to do is change thefont-size
value of the root element (html element), and all dimensions dependent on these units will automatically scale. (https://www.freecodecamp.org/news/css-units-when-to-use-each-one/) - Files: You may be interested in implementing elements of the 7-1 pattern in your project, in order to more clearly structure your .scss files (https://sass-guidelin.es/#chapter-architecture)
- Readme: Since English is a globally recognized language, consider writing the readme file in English so most people can understand it. (https://www.freecodecamp.org/news/how-to-write-a-good-readme-file/)
Keep up the good work :)
Marked as helpful1 - Units: Using REM units to specify all dimensions (except very small dimensions such as
- @elCris99Submitted 2 months ago@M-MikosPosted 2 months ago
Hey, nice work :)
Source code: Consider whether your codebase is too complicated. You have a lot of boilerplate code (SCSS setup) that not affect the overall result.
Design: Note the space between the qr code and the text, on your solution it is smaller than on the project.
Good luck!
0