All comments

• 

  Alex•125

  @SignetOHaraSubmitted over 4 years ago

  Please do let me know if there are any areas of my code that can be simplified. Also keen on practicing to make sure my websites are accessible so please recommend anything I can do to improve that too.

  

  Intro component with sign-up form - Sass, Grid, small animation

  1

  01
  

  LukZap•245

  @LukZapPosted over 4 years ago

  Hey, I made pull request with changes I'd do to js part of project. You can merge it if you like.

  https://github.com/SignetOHara/FrontendMentor-IntroComponent/pull/1

  1

  This comment has received 2 repliesShow
• 

  Safa Ruknuddin•385

  @safrukSubmitted over 4 years ago

  I have used 'min-width' media queries for the first time. Is the implementation all right?

  For the colors I have used 'rgba()' value for the 'color' attribute.Is there a way to target hsl/hsla values in a way similar to how I have used rgba here?I tried doing targeting the hsla values but unfortunately it didn't work.

  Any other feedback/criticism would be wecome :)

  

  Responsive landing page using grid and flexbox

  1

  20
  

  LukZap•245

  @LukZapPosted over 4 years ago

  Hi,

  For colors you can define them in your _variables.scss like that: $ColorPrimary: hsl(179, 62%, 43%), and then just import it to your for ex. _grid-component.scss like that: @import './../abstracts/variables';

  And use it:

    &__section-info {
      background-color: $ColorPrimary;
      ...other styles...
    }
  

  1

  This comment has received 6 repliesShow
• 

  GURPRIT•30

  @gur22-09Submitted almost 5 years ago

  any feedback on the form error display or anything else would be appreciated. The way i did it, is not the optimal solution.

  

  Bootstrap,Javascript

  1

  00
  

  LukZap•245

  @LukZapPosted almost 5 years ago

  hi, it will be nice to reset the validation message every time the button is clicked because now they stack on each other. You can try adding a div element below input and in click handler at the beginning set it's innerHtml = '', and then when you check email regex set it's innerHtml to validation message.

  1
• 

  Adetayo Akinsanya•255

  @unkletayoSubmitted almost 5 years ago

  I have issues with flexbox at some point in styling navbars, please I need tutorials on it

  

  Mobile first, CSS griid, CSS Flexbos

  2

  10
  

  LukZap•245

  @LukZapPosted almost 5 years ago

  Hi, I made pull request to your repo with some help. If you need tutorial I think quite nice is: https://css-tricks.com/snippets/css/a-guide-to-flexbox/ and it's nice to make some experiments by yourself with div containing different elements to get what's going on.

  0

  This comment has received 1 replyShow