@centralparksharkSubmitted 4 months ago
Mauricio
@LucknaghAll comments
- @omarsafti09Submitted 4 months ago@LucknaghPosted 4 months ago
It was incredible, just try to reduce the use of 'div' and add other tags to have a more semantic code, such as 'section', 'main'...
0 - @gina-wang-1021Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Trying to implement some best practices and also utilizing media query!
What challenges did you encounter, and how did you overcome them?Googled to figure out how to switch to different pictures in different device sizes.
What specific areas of your project would you like help with?My "card" component has a height of 455.5 instead of 450 as set in Figma when viewed in desktop view, this results in a white space under the image as the desktop image has a height of 450. However, I couldn't figure out why it was behaving this way. I tried solving this problem by switching between min-height and height set on different components, switching between padding and margin, and also not using border-box - none of those worked tho... Any thoughts on why?
- @arjumand07Submitted 4 months ago@LucknaghPosted 4 months ago
My only suggestion is to enlarge the font a little, it may not be visible to some people
Marked as helpful1 - @pamithapandianSubmitted 4 months ago@LucknaghPosted 4 months ago
It looked cool, just be careful with the spacing, next time try adding a space between the image and the top edge and the last button on the bottom edge of the card
0 - @Victor-M-GiraldoSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Made use of some pseudo elements, absolute and relative positioning. Learned about best practices regarding anchor tags and semantic elements.
What challenges did you encounter, and how did you overcome them?I had some trouble with stacking contexts.
- @weslei573Submitted over 1 year ago
as regards the responsive part! wanted to know what do you think? is it right?
