@roomsrioSubmitted over 2 years ago
Hello, I need your help to show me the way to good code practices. All advice will be good to take even the most fussy. Thanks by advance.
Lozie
@LozPilafasAll comments
- @LozPilafasPosted over 2 years ago
i think its really good š !
One small detail, maybe use cursor:pointer on the button !
1 - @LorenzoChioSubmitted over 2 years ago
Hi! Here's my latest challenge. I tried using rem instead of px for font sizes and used css grid for the layout. I don't understand why the <main> is so long though. Any ideas are welcome! Let me know what you think. Thanks!
@LozPilafasPosted over 2 years agoHey!
I think its really good , you could improve it to match the brief by making it mobile friendly:
correct media query to snap when the width is too small correct edge rounding when stacked
(created a pull request to see the suggested code in github)
peace
0 - @Mehemmed77Submitted over 2 years ago
i couldn't figure out a way to do hover and click (i mean effects) together with only css (ofc i know :hover pseudo class) if someone has done it i would like to know thanks!
@LozPilafasPosted over 2 years agoHey! I think its really good!
I also liked the fade hover effect.
Things that you could implement to make it better: *Validate that the user has picked a number before submitting, you could disable the button until a number has been selected (as if you click without it shows 'you have selected undefined from 5').
peace
Marked as helpful0 - @Meteo-Flagyl00Submitted over 2 years ago
I am proud of my work .. and i started getting used to grid ... but still need to learn how to use media Queries to make my projects responsive ... All suggestions are welcome
@LozPilafasPosted over 2 years agoI think it looks great! Only thing i would change to match the brief a bit better and also make the text readable is to change the font color of the light/grey text to some shade darker to make it more readable
Marked as helpful0
