Skip to content
OverviewSolutions
6
Comments
5
LouisVerch
@LouisVerch

All comments

  • LouisVerch•60
    @LouisVerchPosted about 5 hours ago

    Hey ! Nice work using grid on this project and nice jobs on the units as well (vw). Just some quick points that you could improve :

    • On tablets and laptops around the breakpoint for the image switch your image gets stretched along the vertical axis. This has probably something to do with your width percentage that goes from 50 to 80%. I encountered the same issue and played around with gap to display my text correctly.

    • You could setup your colors as variables at the top of your CSS Grid in a pseudo-class :root so you don't have to write them again. You can just call them after and it's easier to modify them especially on collaborative projects.

    0
  • LouisVerch•60
    @LouisVerchPosted about 15 hours ago

    Good job ! Just some help for your future projects :

    • You should do all your css in a separate file. This help other people review your code more easily and give you feedback on it and it makes it easier to identify issues.

    • Your table is coming outside of you container. You can put it inside to contain it and use border collapse so it doesn't overflow and put a max-width of 100%. Same thing for your image.

    • Your are not using the right fonts you can import them from google fonts or find them in the assets/fonts directory and rel them in your CSS or your HTML by clicking on embed : https://fonts.google.com/selection

    Good coding !

    0
  • LouisVerch•60
    @LouisVerchPosted about 15 hours ago

    Nice job ! Well done on marking all the div classes

    0
  • LouisVerch•60
    @LouisVerchPosted about 19 hours ago

    Nice solution !

    If I could give you an advice try to not use px but use rem instead for dimensions as it can be more responsive because pixels don't scale. (16px = 1rem) For the media query, try to build your site mobile-first and apply a media query for bigger displays as Google started to reference website based on media display.

    0
  • LouisVerch•60
    @LouisVerchPosted 1 day ago

    Nice solution !

    0