Skip to content
OverviewSolutions
13
Comments
3
London Joseph
@London-Joe

All comments

  • London Joseph•140
    @London-JoePosted over 1 year ago

    I love everything about the site and I also learnt a lot about how flexbox works from it, because using grid to arrange the card were a bit hectic for me. Also noticed you used grid name classes but not a single grid in the code.

    0
  • DuraBull•220
    @DuraBullSubmitted over 1 year ago

    I feel like I'm starting to get more efficient at what needs to be done, but still get caught up in the tiny details sometimes. Any suggestions on how I could have made this a bit more streamlined?

    Social Proof Section

    1
    London Joseph•140
    @London-JoePosted over 1 year ago

    I love the way you wrote the code for the background image, I personally don't know much about them so it was a bit tricky for me using pseudo elements, then trying to position them properly.

    0
  • Cloud Custodian•80
    @joeterleckiSubmitted over 1 year ago

    I continued with everything I learned up to this point from my previous feedback; however, there is one small prob I can't solve.

    For some reason after setting a width and height to the parent container div and setting the image to fill, the header length is slightly longer than the width resulting in the overlay busting out of the parent div by ~5 pixels. If anyone can help me out with what's wrong with that, I would be grateful.

    Also, all other feedback is welcomed.

    NFT Preview Component | HTM & CSS Responsive Design

    3
    London Joseph•140
    @London-JoePosted over 1 year ago

    I've gone through your code there are no issues, just change the height on your .card-header:hover::before, from 100% to height: calc(100% - 5px); .

    0