@Grigore05Submitted 3 days ago
Lokesh
@Lokesh8055All comments
- @Lokesh8055Posted 3 days ago
Got some feedbacks for this solution:
-
Make sure that your are asking for proper feedback whenever you submit a solution to frontend mentor so that others can better help you out.
-
get into the habit of including a full modern css reset at the start of the styles in every project. Andy Bell or Josh Comeau both have good ones you can look up and use.
-
Look up how and when to write alt text on images. There are some great posts about this in the resources channel on discord. Remember, alt is human-readable content not code. This image is really important, so needs a proper description. It needs to say what the image is (QR code) and where it goes to in this case (to FrontendMentor.io).
-
when building single components like this you still need to consider the context of where that component would be used in a real site. This card would never be used to serve the main heading on a page, so you know it shouldn't have a h1. Use a lower importance heading level like h2 instead.
-
id tag should be used only once per website. if you want to select multiple elements try to use class based selector and give a proper naming convention. you can read this article(https://www.frontendmentor.io/articles/understanding-css-naming-conventions-bem-oocss-smacss-and-suit-css-V6ZZUYs1xz)
-
make sure the component can't hit screen edges by giving a wrapping element a little padding on all sides (eg body or main in this)
-
please updated your Readme.md file properly explaining what you have done. you can go through ReadmeTemplate.md file for better understanding
-
Add screenshots in your code for different screens.
-
use rem units for font sizes, width also.
Marked as helpful0 -
- @emkumaSubmitted 4 days agoWhat are you most proud of, and what would you do differently next time?
At least I attempted to make it responsive.
What challenges did you encounter, and how did you overcome them?Brain fog, helplessness, frustration, anger, setbacks.
Exercise, meditation, coffee.
What specific areas of your project would you like help with?Appreciate getting newbie appropriate feedback.
Try to be respectful.
Thank you.
Eric Kumasaka
@Lokesh8055Posted 3 days agoHi @Eric Kumasaka,
Some suggestions:
- There are some accessibility issue. remove challenge by text from below
- card width looks different in desktop. in Mobile card looks very small and it is shown above instead of center aligned
- Also your github link to code doesn't work.
0 - @Omargarcia21Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Me siento orgulloso de poder hacer este desafio y poder ver mi nivel de css mejora poco a poco.
What challenges did you encounter, and how did you overcome them?El desafio que encontre es el posicinamiento de los elementos, lo pude solucionar con css y un poco de documentación.
What specific areas of your project would you like help with?Todo feedback es bueno, todo es aprendizaje.
@Lokesh8055Posted 4 days ago@Omargarcia21
Few suggestions from the screenshot provided:
- Card, text, spacing, background color everything completely different from original solution.
- please go through your code once again and make sure that you match the design provided by downloading Figma design
0 - @binzamSubmitted 17 days agoWhat specific areas of your project would you like help with?
Don't hesitate to give me feedback on what I can improve.
@Lokesh8055Posted 17 days agoYour solution looks super cool
Keep your screenshots under a single folder
Good Work Binyam
0 - @HsasasbhgfSubmitted 20 days agoWhat are you most proud of, and what would you do differently next time?
I did it in a short time , usually I used to spend many hours to finish a small project
What challenges did you encounter, and how did you overcome them?fixing the width according to the content.
What specific areas of your project would you like help with?I need to know the method of choosing the proper font size measurement.
@Lokesh8055Posted 17 days agoHi Sara,
- Please check the spacing, looks like your content is sticking on to the top
- check the accessibility also
0 - @wuanmSubmitted over 2 years ago
it is my first project .
- @anoshaahmedSubmitted almost 3 years ago
I would appreciate suggestions to improve my code.
@Lokesh8055Posted almost 3 years agoHi Anosha, Site looks good just now worked on this one.
1
