Skip to content
OverviewSolutions
5
Comments
3
Lty
@Lithyie

All comments

  • Lty•110
    @LithyiePosted almost 3 years ago

    Hi, you might use <a> instead of <p> for the "equilibrium" and the creator name as its highly suggested to be links.

    Also you should put your code inside <main> </main> after <body> and change one if your <p> to <h1> cuz every page should have one <h1> (its mostly part of the good practice for SEO and accessibility things) to clean your accessibility issues

    For CSS, i'm not fan of putting active state separated to its related content, it can be confusing imo, thats all i can say, i'm more used to code in LESS now so its automaticly converted to css, i havent read pure css for long time 😅

    Marked as helpful
    1
  • Lty•110
    @LithyiePosted almost 3 years ago

    Design comparison doesnt match live site result so yep idk

    0
  • Pamela Herrera•30
    @pammelitasSubmitted almost 3 years ago

    I had trouble aligning the icons and the text (ethereum and clock), I don't quite understand how to place them together, I put them inside a div, however I wasn't able to align them as smooth as I'd like. Any positive feedback is greatly appreciated, I'm just getting started.

    NFT Preview Card Component

    3
    Lty•110
    @LithyiePosted almost 3 years ago

    Hello,

    For the icons, its possible to add them using pseudo-element :before to your <p> in your css.

    This solution make them easier to place and considering those icons are only used for decoration purpose, it makes your html lighter. (others solutions are also viable tho)

    Regards, Lty

    Marked as helpful
    0