Skip to content
OverviewSolutions
7
Comments
6
Piotr
@LenyPython

All comments

  • Piotr•190
    @LenyPythonPosted almost 3 years ago

    Everything works for me :) Loading content info about the challenge. Border region hover effect and click ability is nice.

    1
  • Braulio Rivas Abad•40
    @brauliorivasSubmitted almost 3 years ago

    I would like to know if useState or any React Hook on the proyect could have an easier way of doing. Also, does my code is clean or "sphagetti". Finally, is it necessary to optimize or is it already "logic" and similar to big tech companies code.

    Countries Hub using React and Sass

    2
    Piotr•190
    @LenyPythonPosted almost 3 years ago

    Your code is readable to me. Is the project finished? I can't filter countries by region. Can't click the select element of regions. Filter from input works.

    0
  • Piotr•190
    @LenyPythonPosted over 3 years ago

    I would add a min-width property to 'content' object ex. 350px. also i would remove second button form 'article__footer-modal'. I would use CSS to add z-index, background, border-radius to one existing. The button should have active state rather than hover effect. Guessing from design pattern. Hope it helps.

    0
  • Aryan Saini•20
    @sainiaryan1911Submitted over 3 years ago

    I updated this design as per previous feedback and suggestions. Please let me know if there are anymore feedback or suggestions to improve my design as well as code.

    HTML, CSS-Flexbox

    2
    Piotr•190
    @LenyPythonPosted over 3 years ago

    Use background color on div img-header and blend-mixin-mode property with multiply attribute and opacity around 0.7, 0.8. Try to add font-weight to header 1. Hopefully that helps.

    Marked as helpful
    0
  • Letlotlo•60
    @LT-WebDevSubmitted over 3 years ago

    Hey Guys!👋

    Finally submitted my first Frontend Mentor Challenge - I must say I'm filled with excitement to have reached this milestone - It's been a long time coming, finally here!

    Please let me know your thoughts and suggestions!

    Thanks again to Frontend Mentor for their awesome challenges, I really love it here!

    Stats Preview Card Component: Mobile-First & Flexbox

    1
    Piotr•190
    @LenyPythonPosted over 3 years ago

    Gr8 job, try to use border-radius: 25px prop on main container, and opacity: .8 on image and it should be perfect.

    Marked as helpful
    0
  • Piotr•190
    @LenyPythonPosted over 3 years ago

    Great Job! I got a tip today to set @media query at higher rate. I would recommend you to do the same and set yours at 750px, so it would look better on tablets. Maybe use some sort of div wrapper for title and first paragraph and set width to 45% of parent/root. This would shorten the text width I guess.

    0