Skip to content
OverviewSolutions
3
Comments
3

L3pereira

@L3pereira50 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

Latest comments

  • Zdn2000•40
    @Zdn2000
    What are you most proud of, and what would you do differently next time?

    学习了button格式的写法，我将把学习的button样式用于我其他的项目中，尤其是运用button的动画效果，让我的项目更美观

    What challenges did you encounter, and how did you overcome them?

    经过前面两个项目，这个项目对我来说已经比较容易了，可能还是在对display这一块掌握还有所欠缺，我希望当像素缩小到一定程度，footer将不显示，直接在媒体选择器里使用display:none即可

    social-links-profile-main

    1
    L3pereira•50
    @L3pereira

    N/A

  • L3pereira•50
    @L3pereira

    x

  • L3pereira•50
    @L3pereira

    In index.html

    in Line 19 we have

            <div class="qr-code-img" role="img" aria-label="QR Code" ></div>></div>

    it should be

            <div class="qr-code-img" role="img" aria-label="QR Code" ></div>

    We should use landmarks like <main> instead of <div>

      <body>
    <main class="container">
      <div class="qr-card" role="main">
        <div class="qr-code-img" role="img" aria-label="QR Code" ></div>
        <div class="text-container">
          <h1 class="font-outfit font-h-bold" role="heading" >
            Improve your front-end skills by building projects
          </h1>
          <p class="font-outfit font-default" role="text">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
        </div>
      </div>
    </main>
  </body>

    We should also include a footer with the author.

    We could also use CSS variables to replace the color slates like:

    :root {
  --slate-300: hsl(212, 45%, 89%);
  --slate-500: hsl(216, 15%, 48%);
  --slate-900: hsl(218, 44%, 22%);
}
    Marked as helpful