Ramiro Damian Gimenez
@KraudKaiserAll comments
- @Benjihunt97Submitted 7 months ago@KraudKaiserPosted 7 months ago
Its a nice clon on your own way.
I really have nothing to say, if you want to do a 100% accuarate clone, you could do it preatty easy.
Nice work
0 - @KerwinAngelesSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I most proud that I can finish this project, I was a little difficult for me the last part because I don't have any idea how it going to work, but finally I did.
What challenges did you encounter, and how did you overcome them?The challenge was that I did not know how table work, because in the last part of the exercise i needed to do a table to set all the information that it needed but was difficult and really needed to use div to complete the challenge,
What specific areas of your project would you like help with?I need help with the last part, the part where It need to do a table to math the correct information. I wanna know how could I do that the last part without using div, I want to use semantic html.
@KraudKaiserPosted 7 months agoNice job mate!
Lets go with the small details if you want the "platinum" page
- The padding for the preparation time is a bit too much on the top
- ingredients paragraph maybe are too small for read, makes tu force the eyes.
- the background color isn't correct for the body, pretty sure you are looking for eggshell
- the nutrition data (right side) should be all starting the left possible.
thats all for the "100%" clone ;)
Marked as helpful0 - @JoaoMafortSubmitted 7 months ago@KraudKaiserPosted 7 months ago
Well, im judging only as a person who wants "100% accuracy" But maybe you had problems or struggles with css, and thats ok, i really had to.
The MUST to do for me is:
- Align the container in the middle of the screen. For this you can use CSS Flexbox and justify content to the center. Or see for a solution yourself
-Use the colors that are provided in the style-guide.md, they will help you to had the 100% accuracy on colors
-
dont use a box shadow on the links
-
And last: FIGHT! FIGHT FOR THAT CONTENT BEING LOCKED IN THE CONTAINER
Good job men. You are on right way to improve and make a nice clon
Marked as helpful0 - @ShayokhShorfuddinSubmitted 7 months ago@KraudKaiserPosted 7 months ago
Great Work. I really couldnt find something to improve. And a pixel to pixel same project is pretty impossible for me.
1 - @AbdullahHamadaxSubmitted 7 months ago@KraudKaiserPosted 7 months ago
amazing card
I only see 2 things to improve:
- The card has a Box Shadow component, very blurry so is hard to appreciate it, but add one ;)
- You could move the sign (challange created by) on the bottom side.
1