Skip to content
OverviewSolutions
5
Comments
3
Mithun U
@Kratos-750

All comments

  • Zenek•150
    @ZenekSolufkaSubmitted over 1 year ago

    All feedback is welcome. I dont know why on opera mobile version is so crack.

    New-homepage

    1
    Mithun U•150
    @Kratos-750Posted over 1 year ago

    Hello @ZenekSolufka, that's a nice solution. This is a good start but looks like you are having trouble with making the site responsive which is a really eessential part of any website in today's world. But you dont have to worry to much since it's no big deal. You can refer to my Solution. I recommend you to rename your js.js file into something like script.js or index.js.

    To enhance your code organization, consider renaming your "js.js" file to something like "script.js" or "index.js". I would be glad to review your code and identify potential issues, but unfortunately, I dont have time for that right now. However, tackling this task on your own will provide a valuable learning opportunity.

    Given that you're new to this, allow me to share a CSS tip. You can effectively use variables in CSS by employing the following approach:

    :root {
    --var_name : value;
}

    This notation will enable you to define and apply variables throughout your stylesheet, enhancing consistency and maintainability. If you have any further inquiries or need additional assistance, feel free to ask. Hope reading this was worth your time :)

    Marked as helpful
    0
  • Eugene Karuna•10
    @eugene-karunaSubmitted almost 2 years ago

    This my first frontend Mentor challenge. Any advise is more then welcome!

    Besides of the css I would like to know if the structure is valid this way?

    Product preview card component

    1
    Mithun U•150
    @Kratos-750Posted almost 2 years ago

    Nice solution

    As for your question about the structure, anything is valid as long as we get the result

    Ohh I think you missed the active status you can temoparily change the css(like background colour) of an element using .element:hover{}, you can also add a transition to make it look better.

    Since it is a simple project i would recommend you to do it without any css frame works since it dosen't showcase your skills

    you can checkout my solution

    Hope this was helpful!!:)

    Marked as helpful
    0
  • Mithun U•150
    @Kratos-750Posted almost 2 years ago

    Nice solution.

    I learnt a bit from it as well.

    But I think you missed the active status for the submit button, you can do this using the .element:hover in css.

    And I hope you have used the colors specified in the style guide , You can store them as variables and use them, It'll make it much easier.

    Ohh and I think you have written a lot of code for your buttons I think you should keep it simple:)

    You can also check out my solution since I tried doing it in a different way and hope you will find some new ideas from it :)

    Hope you find this helpful!! Happy coding!!

    Marked as helpful
    1